From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH] pc: e820 qemu_cfg tables need to be
 packed
Date: Thu, 14 Oct 2010 22:01:26 -0600
Message-ID: <1287115286.2987.34.camel@x201>
References: <20101014183249.23510.29196.stgit@s20.home>
	 <201010142220.26329.arnd@arndb.de> <1287089944.2987.33.camel@x201>
	 <201010142319.09412.arnd@arndb.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
	Jes Sorensen <Jes.Sorensen@redhat.com>, kvm@vger.kernel.org
To: Arnd Bergmann <arnd@arndb.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:62865 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751058Ab0JOEBf (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 15 Oct 2010 00:01:35 -0400
In-Reply-To: <201010142319.09412.arnd@arndb.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, 2010-10-14 at 23:19 +0200, Arnd Bergmann wrote:
> On Thursday 14 October 2010 22:59:04 Alex Williamson wrote:
> > The structs in question only contain 4 & 8 byte elements, so there
> > shouldn't be any change on x86-32 using one-byte aligned packing.
> 
> I'm talking about the alignment of the structure, not the members
> within the structure. The data structure should be compatible, but
> not accesses to it.
> 
> > AFAIK, e820 is x86-only, so we don't need to worry about breaking anyone
> > else.
> 
> You can use qemu to emulate an x86 pc on anything...

You're right, I wasn't thinking about non-x86 emulating x86.  I'll send
a v2 with your suggestion.  Thanks,

Alex