Re: [PATCH 6/8] KVM: assigned dev: Preparation for mask support in userspace

Michael S. Tsirkin
2010-10-24T12:30:01Z

On Sun, Oct 24, 2010 at 08:19:09PM +0800, Sheng Yang wrote:
> >
> > You need a guarantee that MSIX per-vector mask is used for
> > disable_irq/enable_irq, right? I can't see how this provides it.
>
> This one meant to directly operate the mask/unmask bit of the MSI-X table, to
> emulate the mask/unmask behavior that guest want. In the previous patch I used
> enable_irq()/disable_irq(), but they won't directly operate the MSI-X table unless
> it's necessary, and Michael want to read the table in userspace then he prefer
> using mask/unmask directly.

As I said, the main problem was really that the implementation
proposed only works for interrupts used by assigned devices.
I would like for it to work for irqfd as well.

--
MST