From: Gleb Natapov <gleb@redhat.com>
To: avi@redhat.com, mtosatti@redhat.com
Cc: kvm@vger.kernel.org
Subject: [PATCH 1/2] Use defines instead of numbers for cpu hotplug
Date: Sun, 24 Oct 2010 13:00:02 +0200 [thread overview]
Message-ID: <1287918003-7359-1-git-send-email-gleb@redhat.com> (raw)
Signed-off-by: Gleb Natapov <gleb@redhat.com>
---
hw/acpi_piix4.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index 1c8e4e2..1db5ee3 100644
--- a/hw/acpi_piix4.c
+++ b/hw/acpi_piix4.c
@@ -39,6 +39,7 @@
#define PCI_BASE 0xae00
#define PCI_EJ_BASE 0xae08
+#define PIIX4_CPU_HOTPLUG_STATUS 4
#define PIIX4_PCI_HOTPLUG_STATUS 2
struct gpe_regs {
@@ -636,13 +637,13 @@ static void piix4_acpi_system_hot_add_init(PCIBus *bus, PIIX4PMState *s)
#if defined(TARGET_I386)
static void enable_processor(struct gpe_regs *g, int cpu)
{
- g->sts |= 4;
+ g->sts |= PIIX4_CPU_HOTPLUG_STATUS;
g->cpus_sts[cpu/8] |= (1 << (cpu%8));
}
static void disable_processor(struct gpe_regs *g, int cpu)
{
- g->sts |= 4;
+ g->sts |= PIIX4_CPU_HOTPLUG_STATUS;
g->cpus_sts[cpu/8] &= ~(1 << (cpu%8));
}
--
1.7.1
next reply other threads:[~2010-10-24 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 11:00 Gleb Natapov [this message]
2010-10-24 11:00 ` [PATCH 2/2] Fix cpu/pci hotplug to generate level triggered interrupt Gleb Natapov
2010-10-24 14:12 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287918003-7359-1-git-send-email-gleb@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox