From mboxrd@z Thu Jan  1 00:00:00 1970
From: Huang Ying <ying.huang@intel.com>
Subject: Re: [PATCH  -v2] Monitor command: pfa2hva, translate guest
 physical address to host virtual address
Date: Mon, 08 Nov 2010 09:29:28 +0800
Message-ID: <1289179768.3532.3.camel@yhuang-dev>
References: <1288060789.2862.336.camel@yhuang-dev>
	 <20101101160952.GE1429@amt.cnet>  <4CCF0BAB.9000304@linux.vnet.ibm.com>
	 <1288639205.2059.34.camel@yhuang-mobile>
	 <4CCF136D.5080307@linux.vnet.ibm.com>  <4CD58121.2040209@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: Anthony Liguori <aliguori@linux.vnet.ibm.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Andi Kleen <andi@firstfloor.org>,
	Dean Nelson <dnelson@redhat.com>,
	Luiz Capitulino <lcapitulino@redhat.com>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mga11.intel.com ([192.55.52.93]:33900 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753326Ab0KHB3d (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 7 Nov 2010 20:29:33 -0500
In-Reply-To: <4CD58121.2040209@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, 2010-11-07 at 00:24 +0800, Avi Kivity wrote:
> On 11/01/2010 03:22 PM, Anthony Liguori wrote:
> > On 11/01/2010 02:20 PM, Huang Ying wrote:
> >> Yes. As general interface, it may not work so well, but as test
> >> interface, it works quite well and useful.
> >>
> >> Do we have any mechanism to add a test only interface?
> >
> > I'd like to see what Luiz/Markus think but definitely only a human 
> > monitor interface and probably prefix the command with a 'x-' prefix 
> > to indicate that it's not a supported interface.
> >
> 
> Automated testing will want to use qmp.

Yes. The main usage of the interface is automated testing.

> > The documentation should be very clear about the limitations of the 
> > interface and the intended use-case.
> >
> 
> Perhaps a { execute: 'enable-version-specific-commands', arguments: 
> ['pfa2hva'] } ?

Best Regards,
Huang Ying