public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Huang Ying <ying.huang@intel.com>
To: Anthony Liguori <aliguori@linux.vnet.ibm.com>
Cc: Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Andi Kleen <andi@firstfloor.org>,
	Dean Nelson <dnelson@redhat.com>,
	Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [PATCH  -v2] Monitor command: pfa2hva, translate guest physical address to host virtual address
Date: Tue, 09 Nov 2010 11:06:01 +0800	[thread overview]
Message-ID: <1289271961.32087.40.camel@yhuang-dev> (raw)
In-Reply-To: <4CD770E5.9000105@linux.vnet.ibm.com>

On Mon, 2010-11-08 at 11:39 +0800, Anthony Liguori wrote:
> On 11/07/2010 07:29 PM, Huang Ying wrote:
> > On Sun, 2010-11-07 at 00:24 +0800, Avi Kivity wrote:
> >    
> >> On 11/01/2010 03:22 PM, Anthony Liguori wrote:
> >>      
> >>> On 11/01/2010 02:20 PM, Huang Ying wrote:
> >>>        
> >>>> Yes. As general interface, it may not work so well, but as test
> >>>> interface, it works quite well and useful.
> >>>>
> >>>> Do we have any mechanism to add a test only interface?
> >>>>          
> >>> I'd like to see what Luiz/Markus think but definitely only a human
> >>> monitor interface and probably prefix the command with a 'x-' prefix
> >>> to indicate that it's not a supported interface.
> >>>
> >>>        
> >> Automated testing will want to use qmp.
> >>      
> > Yes. The main usage of the interface is automated testing.
> >    
> 
> That's precisely what the command should not be used for.
> 
> You can't assume a gpa -> hva mapping is consistent in an external 
> application.  If you want to implement an interface for testing, you 
> have to push more of the logic into QEMU to avoid the race.

>From the code of cpu_physical_memory_map(), it seems that if the 'addr'
is physical address in RAM, the mapping should be consistent at least
for x86, doesn't it?

Best Regards,
Huang Ying



  parent reply	other threads:[~2010-11-09  3:06 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-26  2:39 [PATCH -v2] Monitor command: pfa2hva, translate guest physical address to host virtual address Huang Ying
2010-11-01 16:09 ` Marcelo Tosatti
2010-11-01 18:49   ` Anthony Liguori
2010-11-01 19:20     ` Huang Ying
2010-11-01 19:22       ` Anthony Liguori
2010-11-04 16:53         ` Luiz Capitulino
2010-11-06 16:24         ` Avi Kivity
2010-11-08  1:29           ` Huang Ying
2010-11-08  3:39             ` Anthony Liguori
2010-11-08 20:46               ` Huang Ying
2010-11-09  3:06               ` Huang Ying [this message]
2010-11-10  6:56               ` Avi Kivity
2010-11-10  6:59                 ` Avi Kivity
2010-11-10  7:41                   ` Huang Ying
2010-11-10  8:28                     ` Avi Kivity
2010-11-10  8:38                       ` Huang Ying
2010-11-10  8:48                         ` Avi Kivity
2010-11-10 16:42                         ` Andi Kleen
2010-11-10 17:08                           ` Avi Kivity
2010-11-10 17:44                             ` Andi Kleen
2010-11-10 17:47                               ` Avi Kivity
2010-11-10 19:16                                 ` Andi Kleen
2010-11-10 20:58                                   ` Avi Kivity
2010-11-10  8:21                 ` Huang Ying
2010-11-10  8:34                   ` Avi Kivity
2010-11-10 16:49                     ` Anthony Liguori
2010-11-11  0:56                       ` Huang Ying
2010-11-11  9:39                         ` Avi Kivity
2010-11-12  1:16                           ` Huang Ying
2010-11-14 11:08                             ` Avi Kivity
2010-11-14 11:09                               ` Avi Kivity
2010-11-15  1:46                               ` Huang Ying
2010-11-15 10:02                                 ` Andi Kleen
2010-11-08  3:37           ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289271961.32087.40.camel@yhuang-dev \
    --to=ying.huang@intel.com \
    --cc=aliguori@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=andi@firstfloor.org \
    --cc=avi@redhat.com \
    --cc=dnelson@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lcapitulino@redhat.com \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox