From: Sheng Yang <sheng@linux.intel.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
kvm@vger.kernel.org, Sheng Yang <sheng@linux.intel.com>
Subject: [PATCH 5/6] KVM: assigned dev: Clean up assigned_device's flag
Date: Mon, 15 Nov 2010 17:15:31 +0800 [thread overview]
Message-ID: <1289812532-3227-6-git-send-email-sheng@linux.intel.com> (raw)
In-Reply-To: <1289812532-3227-1-git-send-email-sheng@linux.intel.com>
Reuse KVM_DEV_ASSIGN_ENABLE_IOMMU for an in-kernel struct didn't make much
sense.
Signed-off-by: Sheng Yang <sheng@linux.intel.com>
---
include/linux/kvm_host.h | 1 +
virt/kvm/assigned-dev.c | 7 ++++---
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 274655b..f09db87 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -500,6 +500,7 @@ struct kvm_guest_msix_entry {
u16 flags;
};
+#define KVM_ASSIGNED_ENABLED_IOMMU (1 << 0)
struct kvm_assigned_dev_kernel {
struct kvm_irq_ack_notifier ack_notifier;
struct work_struct interrupt_work;
diff --git a/virt/kvm/assigned-dev.c b/virt/kvm/assigned-dev.c
index 7c98928..5c6b96d 100644
--- a/virt/kvm/assigned-dev.c
+++ b/virt/kvm/assigned-dev.c
@@ -552,7 +552,8 @@ static int kvm_vm_ioctl_assign_device(struct kvm *kvm,
match->host_segnr = assigned_dev->segnr;
match->host_busnr = assigned_dev->busnr;
match->host_devfn = assigned_dev->devfn;
- match->flags = assigned_dev->flags;
+ if (assigned_dev->flags & KVM_DEV_ASSIGN_ENABLE_IOMMU)
+ match->flags |= KVM_ASSIGNED_ENABLED_IOMMU;
match->dev = dev;
spin_lock_init(&match->assigned_dev_lock);
match->irq_source_id = -1;
@@ -563,7 +564,7 @@ static int kvm_vm_ioctl_assign_device(struct kvm *kvm,
list_add(&match->list, &kvm->arch.assigned_dev_head);
- if (assigned_dev->flags & KVM_DEV_ASSIGN_ENABLE_IOMMU) {
+ if (assigned_dev->flags & KVM_ASSIGNED_ENABLED_IOMMU) {
if (!kvm->arch.iommu_domain) {
r = kvm_iommu_map_guest(kvm);
if (r)
@@ -609,7 +610,7 @@ static int kvm_vm_ioctl_deassign_device(struct kvm *kvm,
goto out;
}
- if (match->flags & KVM_DEV_ASSIGN_ENABLE_IOMMU)
+ if (match->flags & KVM_ASSIGNED_ENABLED_IOMMU)
kvm_deassign_device(kvm, match);
kvm_free_assigned_device(kvm, match);
--
1.7.0.1
next prev parent reply other threads:[~2010-11-15 9:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 9:15 [PATCH 0/6 v5] MSI-X mask support for assigned device Sheng Yang
2010-11-15 9:15 ` [PATCH 1/6] PCI: MSI: Move MSI-X entry definition to pci_regs.h Sheng Yang
2010-11-15 9:15 ` [PATCH 2/6] PCI: Add mask bit definition for MSI-X table Sheng Yang
2010-11-15 9:15 ` [PATCH 3/6] KVM: Move struct kvm_io_device to kvm_host.h Sheng Yang
2010-11-15 9:15 ` [PATCH 4/6] KVM: Add kvm_get_irq_routing_entry() func Sheng Yang
2010-11-17 14:01 ` Avi Kivity
2010-11-18 2:22 ` Sheng Yang
2010-11-18 9:30 ` Avi Kivity
2010-11-18 9:41 ` Michael S. Tsirkin
2010-11-18 11:59 ` Sheng Yang
2010-11-18 12:33 ` Michael S. Tsirkin
2010-11-18 12:40 ` Sheng Yang
2010-11-15 9:15 ` Sheng Yang [this message]
2010-11-15 9:15 ` [PATCH 6/6] KVM: assigned dev: MSI-X mask support Sheng Yang
2010-11-15 9:27 ` [PATCH 6/6 v5 updated] " Sheng Yang
2010-11-16 19:45 ` [PATCH 6/6] " Marcelo Tosatti
2010-11-17 1:29 ` Sheng Yang
2010-11-17 13:35 ` Marcelo Tosatti
2010-11-18 9:43 ` Michael S. Tsirkin
2010-11-17 13:58 ` Avi Kivity
2010-11-18 1:58 ` Sheng Yang
2010-11-18 6:21 ` Michael S. Tsirkin
2010-11-18 6:39 ` Sheng Yang
2010-11-18 9:28 ` Avi Kivity
2010-11-18 9:37 ` Michael S. Tsirkin
2010-11-18 12:08 ` Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289812532-3227-6-git-send-email-sheng@linux.intel.com \
--to=sheng@linux.intel.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox