public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Shane Wang <shane.wang@intel.com>
To: avi@redhat.com, mtosatti@redhat.com
Cc: jan.kiszka@siemens.com, kvm@vger.kernel.org,
	joseph.cihula@intel.com, shane.wang@intel.com
Subject: [PATCH]KVM: VMX: Inform user about INTEL_TXT dependency
Date: Wed, 17 Nov 2010 11:40:17 +0800	[thread overview]
Message-ID: <1289965217-14270-1-git-send-email-shane.wang@intel.com> (raw)

Inform user to either disable TXT in the BIOS or do TXT launch with tboot before enabling KVM since some BIOSes do not set FEATURE_CONTROL_VMXON_ENABLED_OUTSIDE_SMX bit when TXT is enabled.

Signed-off-by: Shane Wang <shane.wang@intel.com>
---
 arch/x86/kvm/vmx.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff -r b1a2deff4c64 arch/x86/kvm/vmx.c
--- a/arch/x86/kvm/vmx.c	Wed Nov 17 12:47:42 2010 -0500
+++ b/arch/x86/kvm/vmx.c	Wed Nov 17 12:49:52 2010 -0500
@@ -1306,8 +1306,11 @@
 			&& tboot_enabled())
 			return 1;
 		if (!(msr & FEATURE_CONTROL_VMXON_ENABLED_OUTSIDE_SMX)
-			&& !tboot_enabled())
+			&& !tboot_enabled()) {
+			printk(KERN_WARNING "kvm: disable TXT in the BIOS or "
+				" activate TXT before enabling KVM\n");
 			return 1;
+		}
 	}
 
 	return 0;

             reply	other threads:[~2010-11-17  3:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17  3:40 Shane Wang [this message]
2010-11-17  7:56 ` [PATCH]KVM: VMX: Inform user about INTEL_TXT dependency Jan Kiszka
2010-11-18  0:35   ` Wang, Shane
2010-11-18 15:28 ` Marcelo Tosatti
  -- strict thread matches above, loose matches on Subject: below --
2010-11-14  9:18 [PATCH] KVM: " Jan Kiszka
2010-11-14 10:30 ` Avi Kivity
2010-11-14 10:41   ` Jan Kiszka
2010-11-14 11:02     ` Avi Kivity
2010-11-16  4:48       ` Wang, Shane
2010-11-16 10:22         ` Jan Kiszka
2010-11-16 13:02           ` Cihula, Joseph
2010-11-16 13:19             ` Jan Kiszka
2010-11-17  1:30               ` Wang, Shane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289965217-14270-1-git-send-email-shane.wang@intel.com \
    --to=shane.wang@intel.com \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=joseph.cihula@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox