From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [PATCH] KVM test: unattended installation cleanup Date: Thu, 18 Nov 2010 12:50:39 -0200 Message-ID: <1290091839.2669.1.camel@freedom> References: <1290091464-8162-1-git-send-email-lmr@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Jason Wang To: autotest@test.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:8854 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758525Ab0KROuq (ORCPT ); Thu, 18 Nov 2010 09:50:46 -0500 In-Reply-To: <1290091464-8162-1-git-send-email-lmr@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 2010-11-18 at 12:44 -0200, Lucas Meneghel Rodrigues wrote: > From: Jason Wang > > This patch does the following things: > > - Drop the built-in tftp/dhcp based unatteded installation for the > following reason: > > 1 It's based on slirp and was not supported by major > distributions. It's only used for linux guest installation and we > can simply replace it with the -kernel method used by network > installation. > 2 The configuration was complex and hard to be shared with network > based installation. After using -kernel method, most of the > configurations could be shared and easy to be configurated. > > In order to achieve this: > > 1 a new option 'boot_path' is used to specifiy the path of the > kernel/initrd from the medium. > 2 autoyast file is detected through the extra_params instead of > kernel_args (which is dropped with tftp option). > > - Re-strucutre the unattaneded installation related configurations and > make them easy to be used and configurated. > > - Move cdrom related params into unattended_install.cdrom variants, > as there's no need to launch with cdrom when testing a guest > installed from network. > > Changes from v1: > - Make possible to execute parallel guest installation (the 1st version > of the patch was using a unique path for initrd.img and vmlinuz inside > the host filesystem). > - Reorganize some of the KVM autotest defaults > > Tested with RHEL/Fedora/Windows installation. OpenSUSE/SLES is untested. Oh, by the way, I've tested the patch with OpenSUSE 11.3 and it works like a charm. I am really really happy to get rid of slirp code dependency, thank you very much Jason! Lucas