From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: "Lukáš Doktor" <ldoktor@redhat.com>
Cc: autotest@test.kernel.org, kvm-autotest@redhat.com, kvm@vger.kernel.org
Subject: Re: [KVM-AUTOTEST] [PATCH 2/2][virtio-console] Fix compatibility with python 2.4.
Date: Thu, 25 Nov 2010 17:04:31 -0200 [thread overview]
Message-ID: <1290711871.3606.2.camel@freedom> (raw)
In-Reply-To: <4CEE8D36.9000100@redhat.com>
On Thu, 2010-11-25 at 17:22 +0100, Lukáš Doktor wrote:
> Dne 23.11.2010 03:30, Amos Kong napsal(a):
> > ----- "Jiří Župka"<jzupka@redhat.com> wrote:
> >
> >> ---
> >
> > After loading your this patch, virtio_console also could not work with older python.
> >
> > Something are not fixed, such as:
> > "return True if self.failed> 0 else False"
> > "PASS"if result[0] else "FAIL"
> > ...
> >
> > I'm testing with 'Python 2.4.3'
>
> Hi,
>
> this fixes only the GUEST (virtio_guest.py) side of the virtio_console
> test. (tested with python 2.4.3 and 2.4.6)
>
> It's possible to fix the host side too but distributions which supports
> only python 2.4 usually supports older versions of KVM without the
> '-device' option we use in the HOST side of the test for creating the
> devices. This change would only make the code less readable with minimal
> income.
>
> Anyway if there's a real demand, we can fix the HOST side too.
The point here is that we're under a larger project, autotest, which
strives to keep py 2.4 compatibility. So yes, we're going to need to fix
the host side too. However, I'd like to point out that you guys have
done an excellent job with the virtio_console test, great code quality.
Cheers,
Lucas
> Cheers,
> Lukáš
> >
> >> def close(self, file):
> >> @@ -339,7 +341,7 @@ class VirtioGuest:
> >> if descriptor != None:
>
> >> --
> >> 1.7.3.2
> > --
> > To unsubscribe from this list: send the line "unsubscribe kvm" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
_______________________________________________
Autotest mailing list
Autotest@test.kernel.org
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
next prev parent reply other threads:[~2010-11-25 19:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1185845527.152951290479344136.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2010-11-23 2:30 ` [KVM-AUTOTEST][PATCH 2/2][virtio-console] Fix compatibility with python 2.4 Amos Kong
2010-11-25 16:22 ` Lukáš Doktor
2010-11-25 19:04 ` Lucas Meneghel Rodrigues [this message]
2010-11-22 13:38 [KVM-AUTOTEST][PATCH 1/2][virtio-console] Add subtest layer and prepare to add new tests Jiří Župka
2010-11-22 13:38 ` [KVM-AUTOTEST][PATCH 2/2][virtio-console] Fix compatibility with python 2.4 Jiří Župka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290711871.3606.2.camel@freedom \
--to=lmr@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm-autotest@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=ldoktor@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox