From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lucas Meneghel Rodrigues <lmr@redhat.com>
Subject: Re: [PATCH] Add support for python2.4 virtio_console.
Date: Fri, 26 Nov 2010 10:24:57 -0200
Message-ID: <1290774297.2578.24.camel@freedom>
References: <1290765500-5106-1-git-send-email-ldoktor@redhat.com>
	 <1290765500-5106-2-git-send-email-ldoktor@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: autotest@test.kernel.org, kvm@vger.kernel.org,
	kvm-autotest@redhat.com, akong@redhat.com, jzupka@redhat.com
To: Lukas Doktor <ldoktor@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:32482 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751328Ab0KZN03 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 26 Nov 2010 08:26:29 -0500
In-Reply-To: <1290765500-5106-2-git-send-email-ldoktor@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, 2010-11-26 at 10:58 +0100, Lukas Doktor wrote:
> From: Ji=C5=99=C3=AD =C5=BDupka <jzupka@redhat.com>


I actually made this patch myself on the v2 I sent to the mailing list
and applied after it. But thanks anyway :)

Lucas

> ---
>  client/tests/kvm/tests/virtio_console.py |   16 +++++++++++-----
>  1 files changed, 11 insertions(+), 5 deletions(-)
>=20
> diff --git a/client/tests/kvm/tests/virtio_console.py b/client/tests/=
kvm/tests/virtio_console.py
> index d69c0a5..3edd051 100644
> --- a/client/tests/kvm/tests/virtio_console.py
> +++ b/client/tests/kvm/tests/virtio_console.py
> @@ -102,7 +102,9 @@ def run_virtio_console(test, params, env):
>              """
>              @return: If any of subtest not pass return True.
>              """
> -            return True if self.failed > 0 else False
> +            if self.failed > 0:
> +                return True
> +            return False
> =20
>          def get_result(self):
>              """
> @@ -121,16 +123,20 @@ def run_virtio_console(test, params, env):
>              for arg in result[2]:
>                  sargs +=3D str(arg) + ","
>              sargs =3D sargs[:-1]
> -            return ("Subtest (%s(%s)):  -->%s") % (result[1], sargs,
> -                                             "PASS"if result[0] else=
 "FAIL")
> +            res =3D "FAIL"
> +            if result[0]:
> +                res =3D "PASS"
> +            return ("Subtest (%s(%s)):  -->%s") % (result[1], sargs,=
res)
> =20
>=20
>          def result_to_string(self, result):
>              """
>              @param result: Result of test.
>              """
> -            return ("Subtest (%s):  -->%s") % (result[1], "PASS"if r=
esult[0]
> -                                                               else =
"FAIL")
> +            res =3D "FAIL"
> +            if result[0]:
> +                res =3D "PASS"
> +            return ("Subtest (%s):  -->%s") % (result[1], res)
> =20
>=20
>          def get_full_text_result(self):