From: Alex Williamson <alex.williamson@redhat.com>
To: Chris Wright <chrisw@redhat.com>
Cc: kvm@vger.kernel.org, ddutile@redhat.com, mst@redhat.com
Subject: Re: [PATCH 2/5] pci: MSI-X capability is 12 bytes, not 16, MSI is 10 bytes
Date: Fri, 03 Dec 2010 12:48:27 -0700 [thread overview]
Message-ID: <1291405707.2895.1.camel@x201> (raw)
In-Reply-To: <20101203193705.GE4511@x200.localdomain>
On Fri, 2010-12-03 at 11:37 -0800, Chris Wright wrote:
> * Alex Williamson (alex.williamson@redhat.com) wrote:
> > Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> > ---
> >
> > hw/pci.h | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/pci.h b/hw/pci.h
> > index 34955d8..7c52637 100644
> > --- a/hw/pci.h
> > +++ b/hw/pci.h
> > @@ -124,8 +124,8 @@ enum {
> >
> > #define PCI_CAPABILITY_CONFIG_MAX_LENGTH 0x60
> > #define PCI_CAPABILITY_CONFIG_DEFAULT_START_ADDR 0x40
> > -#define PCI_CAPABILITY_CONFIG_MSI_LENGTH 0x10
> > -#define PCI_CAPABILITY_CONFIG_MSIX_LENGTH 0x10
> > +#define PCI_CAPABILITY_CONFIG_MSI_LENGTH 0xa
>
> This is variable length.
Yes, but this particular #define is only used by device assignment,
which only uses the minimum sized table. Maybe as a follow-up patch we
should just remove these from pci.h and let device-assignment keep them
private. Thanks,
Alex
next prev parent reply other threads:[~2010-12-03 19:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 19:33 [PATCH 0/5] Extra capabilities for device assignment Alex Williamson
2010-12-03 19:33 ` [PATCH 1/5] device-assignment: Fix off-by-one in header check Alex Williamson
2010-12-03 19:33 ` [PATCH 2/5] pci: MSI-X capability is 12 bytes, not 16, MSI is 10 bytes Alex Williamson
2010-12-03 19:37 ` Chris Wright
2010-12-03 19:48 ` Alex Williamson [this message]
2010-12-03 19:54 ` Chris Wright
2010-12-03 19:33 ` [PATCH 3/5] pci: Error on PCI capability collisions Alex Williamson
2010-12-03 19:34 ` [PATCH 4/5] device-assignment: Error checking when adding capabilities Alex Williamson
2010-12-03 19:34 ` [PATCH 5/5] device-assignment: pass through and stub more PCI caps Alex Williamson
2010-12-06 16:21 ` [PATCH v2 0/5] Extra capabilities for device assignment Alex Williamson
2010-12-06 16:22 ` [PATCH v2 1/5] device-assignment: Fix off-by-one in header check Alex Williamson
2010-12-06 16:22 ` [PATCH v2 2/5] pci: Remove PCI_CAPABILITY_CONFIG_* Alex Williamson
2010-12-06 16:22 ` [PATCH v2 3/5] pci: Error on PCI capability collisions Alex Williamson
2010-12-06 16:22 ` [PATCH v2 4/5] device-assignment: Error checking when adding capabilities Alex Williamson
2010-12-06 16:23 ` [PATCH v2 5/5] device-assignment: pass through and stub more PCI caps Alex Williamson
2010-12-06 16:34 ` [PATCH v2 0/5] Extra capabilities for device assignment Avi Kivity
2010-12-06 16:43 ` Alex Williamson
2010-12-06 17:03 ` Avi Kivity
2010-12-09 15:13 ` Markus Armbruster
2010-12-09 15:32 ` Avi Kivity
2010-12-09 16:17 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291405707.2895.1.camel@x201 \
--to=alex.williamson@redhat.com \
--cc=chrisw@redhat.com \
--cc=ddutile@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox