From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH 2/5] pci: MSI-X capability is 12 bytes, not 16, MSI is 10 bytes Date: Fri, 03 Dec 2010 12:48:27 -0700 Message-ID: <1291405707.2895.1.camel@x201> References: <20101203192343.3579.73722.stgit@s20.home> <20101203193335.3579.25744.stgit@s20.home> <20101203193705.GE4511@x200.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, ddutile@redhat.com, mst@redhat.com To: Chris Wright Return-path: Received: from mx1.redhat.com ([209.132.183.28]:26279 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479Ab0LCTs3 (ORCPT ); Fri, 3 Dec 2010 14:48:29 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oB3JmSid029756 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 3 Dec 2010 14:48:29 -0500 In-Reply-To: <20101203193705.GE4511@x200.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, 2010-12-03 at 11:37 -0800, Chris Wright wrote: > * Alex Williamson (alex.williamson@redhat.com) wrote: > > Signed-off-by: Alex Williamson > > --- > > > > hw/pci.h | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/hw/pci.h b/hw/pci.h > > index 34955d8..7c52637 100644 > > --- a/hw/pci.h > > +++ b/hw/pci.h > > @@ -124,8 +124,8 @@ enum { > > > > #define PCI_CAPABILITY_CONFIG_MAX_LENGTH 0x60 > > #define PCI_CAPABILITY_CONFIG_DEFAULT_START_ADDR 0x40 > > -#define PCI_CAPABILITY_CONFIG_MSI_LENGTH 0x10 > > -#define PCI_CAPABILITY_CONFIG_MSIX_LENGTH 0x10 > > +#define PCI_CAPABILITY_CONFIG_MSI_LENGTH 0xa > > This is variable length. Yes, but this particular #define is only used by device assignment, which only uses the minimum sized table. Maybe as a follow-up patch we should just remove these from pci.h and let device-assignment keep them private. Thanks, Alex