From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH] [qemu-kvm-next-tree] fix compile error of hw/device-assignment.c Date: Thu, 09 Dec 2010 06:38:20 -0700 Message-ID: <1291901900.17031.24.camel@x201> References: <4D007A82.8030604@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Avi Kivity , kvm@vger.kernel.org To: Wei Yongjun Return-path: Received: from mx1.redhat.com ([209.132.183.28]:3882 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753218Ab0LINi0 (ORCPT ); Thu, 9 Dec 2010 08:38:26 -0500 In-Reply-To: <4D007A82.8030604@cn.fujitsu.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 2010-12-09 at 14:43 +0800, Wei Yongjun wrote: > Fix the following compile error in next tree: > CC x86_64-softmmu/device-assignment.o > hw/device-assignment.c: In function =E2=80=98assigned_device_pci_cap_= init=E2=80=99: > hw/device-assignment.c:1463: error: =E2=80=98PCI_PM_CTRL_NO_SOFT_RST=E2= =80=99 undeclared (first use in this function) > hw/device-assignment.c:1463: error: (Each undeclared identifier is re= ported only once > hw/device-assignment.c:1463: error: for each function it appears in.) >=20 > Signed-off-by: Wei Yongjun Interesting, my build environment was finding RST somewhere. Thanks fo= r the fix. Acked-by: Alex Williamson > --- > hw/device-assignment.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/hw/device-assignment.c b/hw/device-assignment.c > index 50c6408..8446cd4 100644 > --- a/hw/device-assignment.c > +++ b/hw/device-assignment.c > @@ -1460,7 +1460,7 @@ static int assigned_device_pci_cap_init(PCIDevi= ce *pci_dev) > /* assign_device will bring the device up to D0, so we don't= need > * to worry about doing that ourselves here. */ > pci_set_word(pci_dev->config + pos + PCI_PM_CTRL, > - PCI_PM_CTRL_NO_SOFT_RST); > + PCI_PM_CTRL_NO_SOFT_RESET); > =20 > pci_set_byte(pci_dev->config + pos + PCI_PM_PPB_EXTENSIONS, = 0); > pci_set_byte(pci_dev->config + pos + PCI_PM_DATA_REGISTER, 0= );