From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH 3/5] pci-assign: Remove suspicious hunk from assigned_dev_pci_read_config Date: Mon, 13 Dec 2010 16:54:18 -0700 Message-ID: <1292284458.2857.137.camel@x201> References: <0c09b59b3b26fce5fb7ac428cd1889d7ba338306.1292282738.git.jan.kiszka@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , kvm@vger.kernel.org, "Michael S. Tsirkin" , Jan Kiszka To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:62593 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755866Ab0LMXyW (ORCPT ); Mon, 13 Dec 2010 18:54:22 -0500 In-Reply-To: <0c09b59b3b26fce5fb7ac428cd1889d7ba338306.1292282738.git.jan.kiszka@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 2010-12-14 at 00:25 +0100, Jan Kiszka wrote: > From: Jan Kiszka > > No one can remember where this came from, and it looks very hacky > anyway (we return 0 for config space address 0xfc of _every_ assigned > device, not only vga as the comment claims). So better remove it and > wait for the underlying issue to reappear. > > Signed-off-by: Jan Kiszka > --- > hw/device-assignment.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) Yay! Acked-by: Alex Williamson > diff --git a/hw/device-assignment.c b/hw/device-assignment.c > index 6ff1456..ef045f4 100644 > --- a/hw/device-assignment.c > +++ b/hw/device-assignment.c > @@ -508,10 +508,6 @@ static uint32_t assigned_dev_pci_read_config(PCIDevice *d, uint32_t address, > return val; > } > > - /* vga specific, remove later */ > - if (address == 0xFC) > - goto do_log; > - > fd = pci_dev->real_device.config_fd; > > again: > @@ -526,7 +522,6 @@ again: > exit(1); > } > > -do_log: > DEBUG("(%x.%x): address=%04x val=0x%08x len=%d\n", > (d->devfn >> 3) & 0x1F, (d->devfn & 0x7), address, val, len); >