Re: [RFC -v2 PATCH 2/3] sched: add yield_to function

Srivatsa Vaddagiri
2010-12-14T10:24:15Z

On Tue, Dec 14, 2010 at 07:08:16AM +0100, Mike Galbraith wrote:
> > +/*
> > + * Yield the CPU, giving the remainder of our time slice to task p.
> > + * Typically used to hand CPU time to another thread inside the same
> > + * process, eg. when p holds a resource other threads are waiting for.
> > + * Giving priority to p may help get that resource released sooner.
> > + */
> > +void yield_to(struct task_struct *p)
> > +{
> > + unsigned long flags;
> > + struct rq *rq, *p_rq;
> > +
> > + local_irq_save(flags);
> > + rq = this_rq();
> > +again:
> > + p_rq = task_rq(p);
> > + double_rq_lock(rq, p_rq);
> > + if (p_rq != task_rq(p)) {
> > + double_rq_unlock(rq, p_rq);
> > + goto again;
> > + }
> > +
> > + /* We can't yield to a process that doesn't want to run. */
> > + if (!p->se.on_rq)
> > + goto out;
> > +
> > + /*
> > + * We can only yield to a runnable task, in the same schedule class
> > + * as the current task, if the schedule class implements yield_to_task.
> > + */
> > + if (!task_running(rq, p) && current->sched_class == p->sched_class &&
> > + current->sched_class->yield_to)
> > + current->sched_class->yield_to(rq, p);
> > +
> > +out:
> > + double_rq_unlock(rq, p_rq);
> > + local_irq_restore(flags);
> > + yield();
> > +}
> > +EXPORT_SYMBOL_GPL(yield_to);
>
> That part looks ok, except for the yield cross cpu bit. Trying to yield
> a resource you don't have doesn't make much sense to me.

So another (crazy) idea is to move the "yieldee" task on another cpu over to
yielding task's cpu, let it run till the end of yielding tasks slice and then
let it go back to the original cpu at the same vruntime position!

- vatsa