From: Huang Ying <ying.huang@intel.com>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Andi Kleen <andi@firstfloor.org>, Tony Luck <tony.luck@intel.com>,
ying.huang@intel.com, Dean Nelson <dnelson@redhat.com>
Subject: [RFC 2/3] KVM, Replace is_hwpoison_address with get_user_pages_hwpoison
Date: Wed, 22 Dec 2010 10:51:56 +0800 [thread overview]
Message-ID: <1292986317-2805-3-git-send-email-ying.huang@intel.com> (raw)
In-Reply-To: <1292986317-2805-1-git-send-email-ying.huang@intel.com>
is_hwpoison_address only checks whether the page table entry is
hwpoisoned, regardless the memory page mapped. While
get_user_pages_hwpoison will check both.
In a following patch, we will introduce unpoison_address, which will
clear the poisoned page table entry to make it possible to allocate a
new memory page for the virtual address. But it is also possible that
the underlying memory page is kept poisoned even after the
corresponding page table entry is cleared, that is, a new memory page
can not be allocated. get_user_pages_hwpoison can catch these
situations.
Signed-off-by: Huang Ying <ying.huang@intel.com>
---
include/linux/mm.h | 8 --------
mm/memory-failure.c | 32 --------------------------------
virt/kvm/kvm_main.c | 4 +++-
3 files changed, 3 insertions(+), 41 deletions(-)
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -1512,14 +1512,6 @@ extern int sysctl_memory_failure_recover
extern void shake_page(struct page *p, int access);
extern atomic_long_t mce_bad_pages;
extern int soft_offline_page(struct page *page, int flags);
-#ifdef CONFIG_MEMORY_FAILURE
-int is_hwpoison_address(unsigned long addr);
-#else
-static inline int is_hwpoison_address(unsigned long addr)
-{
- return 0;
-}
-#endif
extern void dump_page(struct page *page);
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -1433,35 +1433,3 @@ done:
/* keep elevated page count for bad page */
return ret;
}
-
-/*
- * The caller must hold current->mm->mmap_sem in read mode.
- */
-int is_hwpoison_address(unsigned long addr)
-{
- pgd_t *pgdp;
- pud_t pud, *pudp;
- pmd_t pmd, *pmdp;
- pte_t pte, *ptep;
- swp_entry_t entry;
-
- pgdp = pgd_offset(current->mm, addr);
- if (!pgd_present(*pgdp))
- return 0;
- pudp = pud_offset(pgdp, addr);
- pud = *pudp;
- if (!pud_present(pud) || pud_large(pud))
- return 0;
- pmdp = pmd_offset(pudp, addr);
- pmd = *pmdp;
- if (!pmd_present(pmd) || pmd_large(pmd))
- return 0;
- ptep = pte_offset_map(pmdp, addr);
- pte = *ptep;
- pte_unmap(ptep);
- if (!is_swap_pte(pte))
- return 0;
- entry = pte_to_swp_entry(pte);
- return is_hwpoison_entry(entry);
-}
-EXPORT_SYMBOL_GPL(is_hwpoison_address);
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -966,7 +966,9 @@ static pfn_t hva_to_pfn(struct kvm *kvm,
goto return_fault_page;
down_read(¤t->mm->mmap_sem);
- if (is_hwpoison_address(addr)) {
+ npages = get_user_pages_hwpoison(current, current->mm,
+ addr, 1, 1, 0, page, NULL);
+ if (npages == -EHWPOISON) {
up_read(¤t->mm->mmap_sem);
get_page(hwpoison_page);
return page_to_pfn(hwpoison_page);
next prev parent reply other threads:[~2010-12-22 2:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-22 2:51 [RFC 0/3] KVM, HWPoison, unpoison address across rebooting Huang Ying
2010-12-22 2:51 ` [RFC 1/3] mm, Make __get_user_pages return -EHWPOISON for HWPOISON page optionally Huang Ying
2010-12-22 23:07 ` Andrew Morton
2010-12-23 0:39 ` Huang Ying
2010-12-23 0:54 ` Andrew Morton
2010-12-22 2:51 ` Huang Ying [this message]
2010-12-22 2:51 ` [RFC 3/3] KVM, HWPoison, unpoison address across rebooting Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292986317-2805-3-git-send-email-ying.huang@intel.com \
--to=ying.huang@intel.com \
--cc=andi@firstfloor.org \
--cc=avi@redhat.com \
--cc=dnelson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox