Re: [PATCH 2/2][RFC] KVM: Emulate MSI-X table and PBA in kernel

Avi Kivity
2010-12-30T09:28:50Z

On 12/30/2010 09:32 AM, Sheng Yang wrote:
> >
> > I don't think it's going to work: we are not
> > in the context of the right process. Further
> > I think we should keep the option of
> > reading the PBA status from the device or host kernel open.
> > And generally having an interface
> > for functionality we don't implement is not a good idea:
> > you don't know whether you really can support the interface you promised.
>
> Well, I don't know if we want to read PBA from device directly. To me it's not a
> good idea because the real device has nothing to do with the one we show to the
> guest.

Right. vPBA.bit = pPBA.bit |
recorded_pending_bit_from_lazy_masked_interrupt.

> At least direct accessing the mask bits of real device would be very
> dangerous. Avi?

Agree.

--
error compiling committee.c: too many arguments to function