From mboxrd@z Thu Jan 1 00:00:00 1970 From: Huang Ying Subject: Re: QEMU, MCE, unpoison memory address across reboot Date: Tue, 28 Dec 2010 16:35:32 +0800 Message-ID: <1293525332.22308.241.camel@yhuang-dev> References: <1292986371.8743.113.camel@yhuang-dev> <20101223142803.GD17819@amt.cnet> <4D1734AE.30909@redhat.com> <20101227212754.GB13518@amt.cnet> <20101228082709.GT2231@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Avi Kivity , "kvm@vger.kernel.org" , Andi Kleen , Dean Nelson To: Gleb Natapov Return-path: Received: from mga11.intel.com ([192.55.52.93]:54337 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751571Ab0L1Ify (ORCPT ); Tue, 28 Dec 2010 03:35:54 -0500 In-Reply-To: <20101228082709.GT2231@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 2010-12-28 at 16:27 +0800, Gleb Natapov wrote: > On Mon, Dec 27, 2010 at 07:27:54PM -0200, Marcelo Tosatti wrote: > > On Sun, Dec 26, 2010 at 02:27:26PM +0200, Avi Kivity wrote: > > > >> +static void kvm_unpoison_all(void *param) > > > >> +{ > > > >> + HWPoisonPage *page, *next_page; > > > >> + unsigned long address; > > > >> + KVMState *s = param; > > > >> + > > > >> + QLIST_FOREACH_SAFE(page,&hwpoison_page_list, list, next_page) { > > > >> + address = (unsigned long)page->vaddr; > > > >> + QLIST_REMOVE(page, list); > > > >> + kvm_vm_ioctl(s, KVM_UNPOISON_ADDRESS, address); > > > >> + qemu_free(page); > > > >> + } > > > >> +} > > > > > > > >Can't you free and reallocate all guest memory instead, on reboot, if > > > >there's a hwpoisoned page? Then you don't need this interface. > > > > > > > > > > Alternatively, MADV_DONTNEED? We already use it for ballooning. > > > > Does not work for hugetlbfs. > > > Don't we break huge page to 4k pages during poisoning? Yes. That has not been implemented yet. So in fact, we can not deal with hwpoison+hugetlb in kvm now. Best Regards, Huang Ying