From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: autotest@test.kernel.org
Cc: Eduardo Habkost <ehabkost@redhat.com>, kvm@vger.kernel.org
Subject: [PATCH 5/8] KVM test: installer: fix the 'layout 1' detection
Date: Wed, 29 Dec 2010 20:37:27 -0200 [thread overview]
Message-ID: <1293662250-18292-6-git-send-email-lmr@redhat.com> (raw)
In-Reply-To: <1293662250-18292-1-git-send-email-lmr@redhat.com>
From: Eduardo Habkost <ehabkost@redhat.com>
The common (or only) case where we have a 'qemu' directory (old KVM
versions) also contains a 'kvm' directory, so the detection of the 'old
layout' code was not working.
Fix this by removing the 'and not has_kvm_dir' condition.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
client/tests/kvm/kvm_utils.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py
index 1967ddd..d135979 100644
--- a/client/tests/kvm/kvm_utils.py
+++ b/client/tests/kvm/kvm_utils.py
@@ -445,7 +445,7 @@ def check_kvm_source_dir(source_dir):
os.chdir(source_dir)
has_qemu_dir = os.path.isdir('qemu')
has_kvm_dir = os.path.isdir('kvm')
- if has_qemu_dir and not has_kvm_dir:
+ if has_qemu_dir:
logging.debug("qemu directory detected, source dir layout 1")
return 1
if has_kvm_dir and not has_qemu_dir:
--
1.7.2.3
next prev parent reply other threads:[~2010-12-29 22:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-29 22:37 [PATCH 0/8] KVM test: Build code refactor + module_probe test Lucas Meneghel Rodrigues
2010-12-29 22:37 ` [PATCH 1/8] KVM test: Refactor the KVM build code into installer Lucas Meneghel Rodrigues
2010-12-29 22:37 ` [PATCH 2/8] KVM test: rename 'mode' to 'install_mode' on the sample cfg files Lucas Meneghel Rodrigues
2010-12-29 22:37 ` [PATCH 3/8] KVM test: add methods to store a installer object in 'env' Lucas Meneghel Rodrigues
2010-12-29 22:37 ` [PATCH 4/8] KVM test: Make the build test to use the installer library Lucas Meneghel Rodrigues
2010-12-29 22:37 ` Lucas Meneghel Rodrigues [this message]
2010-12-29 22:37 ` [PATCH 6/8] KVM test: load/unload kvm module Lucas Meneghel Rodrigues
2010-12-29 22:37 ` [PATCH 7/8] KVM test: add interface to get modules from cfg file, and load/unload them Lucas Meneghel Rodrigues
2010-12-29 22:37 ` [PATCH 8/8] KVM test: test/module_probe: use installer object to load modules Lucas Meneghel Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1293662250-18292-6-git-send-email-lmr@redhat.com \
--to=lmr@redhat.com \
--cc=autotest@test.kernel.org \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox