From: Michael Goldish <mgoldish@redhat.com>
To: autotest@test.kernel.org, kvm@vger.kernel.org
Cc: Michael Goldish <mgoldish@redhat.com>
Subject: [KVM-AUTOTEST PATCH 5/7] [RFC] Set the .context attribute for exceptions in _call_test_function()
Date: Mon, 3 Jan 2011 20:34:09 +0200 [thread overview]
Message-ID: <1294079651-21631-5-git-send-email-mgoldish@redhat.com> (raw)
In-Reply-To: <1294079651-21631-1-git-send-email-mgoldish@redhat.com>
Before passing exceptions on up, inject context information into them which can
later be used by __str__().
Signed-off-by: Michael Goldish <mgoldish@redhat.com>
---
client/common_lib/test.py | 16 ++++++++++------
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/client/common_lib/test.py b/client/common_lib/test.py
index 2561242..9521326 100644
--- a/client/common_lib/test.py
+++ b/client/common_lib/test.py
@@ -596,13 +596,17 @@ def _call_test_function(func, *args, **dargs):
inside test code are considered test failures."""
try:
return func(*args, **dargs)
- except error.AutotestError:
- # Pass already-categorized errors on up as is.
- raise
+ except error.AutotestError, e:
+ # Inject context info and pass already-categorized errors on up.
+ e.context = error.get_context(sys.exc_info()[2])
+ raise sys.exc_info()[0], e, sys.exc_info()[2]
except Exception, e:
- # Other exceptions must be treated as a FAIL when
- # raised during the test functions
- raise error.UnhandledTestFail(e)
+ # Other exceptions are treated as a FAIL when raised during the test
+ # functions. Convert them to UnhandledTestFail, inject context info
+ # and pass them on up.
+ e = error.UnhandledTestFail(e)
+ e.context = error.get_context(sys.exc_info()[2])
+ raise e
def runtest(job, url, tag, args, dargs,
--
1.7.3.4
next prev parent reply other threads:[~2011-01-03 18:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 18:34 [KVM-AUTOTEST PATCH 1/7] [RFC] Fix Unhandled* exceptions Michael Goldish
2011-01-03 18:34 ` [KVM-AUTOTEST PATCH 2/7] [RFC] CmdError: remove extra blank line between methods Michael Goldish
2011-01-03 18:34 ` [KVM-AUTOTEST PATCH 3/7] [RFC] Introduce exception context strings Michael Goldish
2011-01-03 19:26 ` Eduardo Habkost
2011-01-03 19:42 ` [Autotest] " Eduardo Habkost
2011-01-03 19:48 ` Michael Goldish
2011-01-03 20:16 ` Eduardo Habkost
2011-01-03 21:07 ` Michael Goldish
2011-01-03 21:22 ` Eduardo Habkost
2011-01-03 22:06 ` [Autotest] " Eduardo Habkost
2011-01-03 22:56 ` Michael Goldish
2011-01-04 15:08 ` Eduardo Habkost
2011-01-04 15:20 ` Eduardo Habkost
2011-01-03 20:26 ` Eduardo Habkost
2011-01-03 20:41 ` [Autotest] " Michael Goldish
2011-01-03 18:34 ` [KVM-AUTOTEST PATCH 4/7] [RFC] Embed context information in exception strings Michael Goldish
2011-01-03 18:34 ` Michael Goldish [this message]
2011-01-03 18:34 ` [KVM-AUTOTEST PATCH 6/7] [RFC] KVM test: use error.context() in migration_with_file_transfer Michael Goldish
2011-01-03 18:34 ` [KVM-AUTOTEST PATCH 7/7] [RFC] KVM test: use error.context() in kvm_preprocessing.py Michael Goldish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294079651-21631-5-git-send-email-mgoldish@redhat.com \
--to=mgoldish@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox