public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Goldish <mgoldish@redhat.com>
To: autotest@test.kernel.org, kvm@vger.kernel.org
Subject: [KVM-AUTOTEST PATCH 6/7] [RFC] KVM test: use error.context() in migration_with_file_transfer
Date: Mon,  3 Jan 2011 20:34:10 +0200	[thread overview]
Message-ID: <1294079651-21631-6-git-send-email-mgoldish@redhat.com> (raw)
In-Reply-To: <1294079651-21631-1-git-send-email-mgoldish@redhat.com>

This is an example of a case where context information is useful.

Signed-off-by: Michael Goldish <mgoldish@redhat.com>
---
 .../kvm/tests/migration_with_file_transfer.py      |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/client/tests/kvm/tests/migration_with_file_transfer.py b/client/tests/kvm/tests/migration_with_file_transfer.py
index 27c1fe1..d0159c5 100644
--- a/client/tests/kvm/tests/migration_with_file_transfer.py
+++ b/client/tests/kvm/tests/migration_with_file_transfer.py
@@ -47,24 +47,26 @@ def run_migration_with_file_transfer(test, params, env):
             finally:
                 bg.join()
 
-        logging.info("Transferring file from host to guest")
+        error.context("transferring file to guest while migrating")
         bg = kvm_utils.Thread(vm.copy_files_to,
                               (host_path, guest_path, 0, transfer_timeout))
         run_and_migrate(bg)
 
-        logging.info("Transferring file back from guest to host")
+        error.context("transferring file back to host while migrating")
         bg = kvm_utils.Thread(vm.copy_files_from,
                               (guest_path, host_path_returned, 0,
                                transfer_timeout))
         run_and_migrate(bg)
 
-        # Make sure the returned file is indentical to the original one
+        # Make sure the returned file is identical to the original one
+        error.context("comparing hashes")
         orig_hash = client_utils.hash_file(host_path)
         returned_hash = client_utils.hash_file(host_path_returned)
         if orig_hash != returned_hash:
             raise error.TestFail("Returned file hash (%s) differs from "
                                  "original one (%s)" % (returned_hash,
                                                         orig_hash))
+        error.context("cleanup")
     finally:
         session.close()
         if os.path.isfile(host_path):
-- 
1.7.3.4

  parent reply	other threads:[~2011-01-03 18:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-03 18:34 [KVM-AUTOTEST PATCH 1/7] [RFC] Fix Unhandled* exceptions Michael Goldish
2011-01-03 18:34 ` [KVM-AUTOTEST PATCH 2/7] [RFC] CmdError: remove extra blank line between methods Michael Goldish
2011-01-03 18:34 ` [KVM-AUTOTEST PATCH 3/7] [RFC] Introduce exception context strings Michael Goldish
2011-01-03 19:26   ` Eduardo Habkost
2011-01-03 19:42     ` [Autotest] " Eduardo Habkost
2011-01-03 19:48     ` Michael Goldish
2011-01-03 20:16       ` Eduardo Habkost
2011-01-03 21:07         ` Michael Goldish
2011-01-03 21:22           ` Eduardo Habkost
2011-01-03 22:06             ` [Autotest] " Eduardo Habkost
2011-01-03 22:56               ` Michael Goldish
2011-01-04 15:08                 ` Eduardo Habkost
2011-01-04 15:20                 ` Eduardo Habkost
2011-01-03 20:26   ` Eduardo Habkost
2011-01-03 20:41     ` [Autotest] " Michael Goldish
2011-01-03 18:34 ` [KVM-AUTOTEST PATCH 4/7] [RFC] Embed context information in exception strings Michael Goldish
2011-01-03 18:34 ` [KVM-AUTOTEST PATCH 5/7] [RFC] Set the .context attribute for exceptions in _call_test_function() Michael Goldish
2011-01-03 18:34 ` Michael Goldish [this message]
2011-01-03 18:34 ` [KVM-AUTOTEST PATCH 7/7] [RFC] KVM test: use error.context() in kvm_preprocessing.py Michael Goldish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294079651-21631-6-git-send-email-mgoldish@redhat.com \
    --to=mgoldish@redhat.com \
    --cc=autotest@test.kernel.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox