From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [RFC -v3 PATCH 2/3] sched: add yield_to function Date: Wed, 05 Jan 2011 18:15:18 +0100 Message-ID: <1294247718.2016.269.camel@laptop> References: <20110103162637.29f23c40@annuminas.surriel.com> <20110103162918.577a9620@annuminas.surriel.com> <1294164289.2016.186.camel@laptop> <4D24A5F4.3000508@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Cc: Rik van Riel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Srivatsa Vaddagiri , Mike Galbraith , Chris Wright To: Avi Kivity Return-path: In-Reply-To: <4D24A5F4.3000508@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, 2011-01-05 at 19:10 +0200, Avi Kivity wrote: > On 01/04/2011 08:04 PM, Peter Zijlstra wrote: > > This definitely wants to be EXPORT_SYMBOL_GPL() and if it were possible > > I'd make it so only kvm.o could use it. It really sucks that kvm is a > > module. > > Why does it suck? I mean apart from the "virtualization is crap" song. Because it needs hooks all over the core kernel, like this yield_to() stuff. Exporting this might lead to others wanting to use it too.