public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: Peter Feiner <pfeiner@google.com>,
	kvm@vger.kernel.org, David Matlack <dmatlack@google.com>
Subject: Re: [kvm-unit-tests PATCH 1/3] x86/vmx: fix EPT - MMIO access
Date: Mon, 3 Jul 2017 13:28:33 -0400 (EDT)	[thread overview]
Message-ID: <1295348587.13934368.1499102913946.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170703171343.GB30880@potion>



----- Original Message -----
> From: "Radim Krčmář" <rkrcmar@redhat.com>
> To: "Paolo Bonzini" <pbonzini@redhat.com>
> Cc: "Peter Feiner" <pfeiner@google.com>, kvm@vger.kernel.org, "David Matlack" <dmatlack@google.com>
> Sent: Monday, July 3, 2017 7:13:44 PM
> Subject: Re: [kvm-unit-tests PATCH 1/3] x86/vmx: fix EPT - MMIO access
> 
> 2017-06-30 12:22+0200, Paolo Bonzini:
> > On 29/06/2017 19:34, Peter Feiner wrote:
> > > Reading the memory mapped page with x2apic is a bug.  Use the generic
> > > reader
> > > instead.  An alternative would be to disable x2apic.
> > 
> > Disabling x2apic would test what the test is supposed to test. :)
> 
> We should still be doing the same --  we're interested in testing the
> MMIO access from the guest, which is being done in ept_main().
> 
> ept_init_common() is used just to access the reference value and I think
> that allowing x2APIC there gives us a bit more leeway,

Thanks for the explanation.  You're obviously right, will apply tomorrow
with an improved commit message.

Paolo

  reply	other threads:[~2017-07-03 17:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29 17:26 [kvm-unit-tests PATCH 0/3] x86/vmx: fix vmx_EPT_AD_* tests Radim Krčmář
2017-06-29 17:26 ` [kvm-unit-tests PATCH 1/3] x86/vmx: fix EPT - MMIO access Radim Krčmář
2017-06-29 17:34   ` Peter Feiner
2017-06-30 10:22     ` Paolo Bonzini
2017-07-03 17:13       ` Radim Krčmář
2017-07-03 17:28         ` Paolo Bonzini [this message]
2017-06-29 17:26 ` [kvm-unit-tests PATCH 2/3] x86/vmx: fix detection of unmapped PTE Radim Krčmář
2017-06-29 17:38   ` Peter Feiner
2017-06-30 10:33   ` Paolo Bonzini
2017-07-03 10:34     ` Paolo Bonzini
2017-07-03 16:42       ` Radim Krčmář
2017-06-29 17:26 ` [kvm-unit-tests PATCH 3/3] x86/vmx: get EPT at the last level Radim Krčmář
2017-06-29 17:51   ` Peter Feiner
2017-06-29 18:08     ` Radim Krčmář
2017-06-29 18:17       ` Peter Feiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295348587.13934368.1499102913946.JavaMail.zimbra@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=dmatlack@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=pfeiner@google.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox