From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH 2/3] kvm hypervisor : Add hypercalls to support pv-ticketlock Date: Thu, 20 Jan 2011 14:41:46 +0100 Message-ID: <1295530906.28776.171.camel@laptop> References: <20110119164432.GA30669@linux.vnet.ibm.com> <20110119171239.GB726@linux.vnet.ibm.com> <1295457672.28776.144.camel@laptop> <4D373340.60608@goop.org> <20110120115958.GB11177@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: Mathieu, Xen-devel , Desnoyers , Nick Piggin , Jeremy, Linux, Jeremy Fitzhardinge , Beulich , Linux Kernel Mailing List , Jan, Fitzhardinge , suzuki@in.ibm.com, Avi Kivity , kvm@vger.kernel.org, "H. Peter Anvin" , =?ISO-8859-1?Q?Am=E9rico?= Wang , Eric Dumazet , Virtualization To: vatsa@linux.vnet.ibm.com Return-path: In-Reply-To: <20110120115958.GB11177@linux.vnet.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com List-Id: kvm.vger.kernel.org On Thu, 2011-01-20 at 17:29 +0530, Srivatsa Vaddagiri wrote: >=20 > If we had a yield-to [1] sort of interface _and_ information on which vcp= u > owns a lock, then lock-spinners can yield-to the owning vcpu,=20 and then I'd nak it for being stupid ;-) really, yield*() is retarded, never even consider using it. If you've got the actual owner you can do full blown PI, which is tons better than a 'do-something-random' call. The only reason the whole non-virt pause loop filtering muck uses it is because it really doesn't know anything, and do-something is pretty much all it can do. Its a broken interface.