From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH v2 5/6] KVM-GST: adjust scheduler cpu power Date: Tue, 01 Feb 2011 17:19:28 +0100 Message-ID: <1296577168.26581.240.camel@laptop> References: <1296244340-15173-1-git-send-email-glommer@redhat.com> <1296244340-15173-6-git-send-email-glommer@redhat.com> <1296473120.15234.375.camel@laptop> <1296575996.5081.20.camel@mothafucka.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, aliguori@us.ibm.com, Rik van Riel , Jeremy Fitzhardinge , Avi Kivity To: Glauber Costa Return-path: In-Reply-To: <1296575996.5081.20.camel@mothafucka.localdomain> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Tue, 2011-02-01 at 13:59 -0200, Glauber Costa wrote: > > Because that part is kvm-specific, and this is scheduler general. > It seemed cleaner to me to do it this way. But I can do it differently, > certainly. Well, any steal time clock will be hypervisor specific, but if we agree that anything that enables CONFIG_PARAVIRT_TIME_ACCOUNTING provides a u64 steal_time_clock(int cpu) function then all should be well, right? The bit you have in kvm is almost that, except it assumes cpu == this_cpu. You simply cannot rely on the silly tick accounting to drive any clock, its archaic.