public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH 0/2] SVM NMI fixes
Date: Thu,  3 Feb 2011 17:02:47 +0200	[thread overview]
Message-ID: <1296745369-12066-1-git-send-email-avi@redhat.com> (raw)

There are a couple of fairly severe problems with NMI on AMD, both triggered
with nmi_watchdog=1 in the guest and kvm ftrace in the host.  One of the bug
leads to guest userspace crashes via spurious setting of EFLAGS.TF, while the
other leads to guest kernel hangs looping on the NMI handler's IRET
instruction.  I believe ftrace only affects timing here, and is not a real
requirement to reproduce the bug.

See https://bugzilla.redhat.com/show_bug.cgi?id=612436 for the original report.

I will try to write unit tests for both issues.

Avi Kivity (2):
  KVM: Fix race between nmi injection and enabling nmi window
  KVM: SVM: check for progress after IRET interception

 arch/x86/kvm/svm.c       |   10 +++++++++-
 arch/x86/kvm/x86.c       |    4 +++-
 include/linux/kvm_host.h |    1 +
 3 files changed, 13 insertions(+), 2 deletions(-)


             reply	other threads:[~2011-02-03 15:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-03 15:02 Avi Kivity [this message]
2011-02-03 15:02 ` [PATCH 1/2] KVM: Fix race between nmi injection and enabling nmi window Avi Kivity
2011-02-03 15:11   ` Jan Kiszka
2011-02-03 15:15     ` Avi Kivity
2011-02-03 15:02 ` [PATCH 2/2] KVM: SVM: check for progress after IRET interception Avi Kivity
2011-02-03 15:07   ` Avi Kivity
2011-02-03 15:21     ` Jan Kiszka
2011-02-03 15:30       ` Avi Kivity
2011-02-03 15:55         ` Jan Kiszka
2011-02-03 15:58           ` Avi Kivity
2011-02-03 16:14             ` Jan Kiszka
2011-02-03 16:20               ` Avi Kivity
2011-02-03 16:30                 ` Jan Kiszka
2011-02-08 13:49     ` Marcelo Tosatti
2011-02-08 14:05       ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296745369-12066-1-git-send-email-avi@redhat.com \
    --to=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=joerg.roedel@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox