From mboxrd@z Thu Jan 1 00:00:00 1970 From: Huang Ying Subject: Re: [PATCH uq/master -v2 2/2] KVM, MCE, unpoison memory address across reboot Date: Fri, 11 Feb 2011 09:20:11 +0800 Message-ID: <1297387211.30902.39.camel@yhuang-dev> References: <1297220431.5180.15.camel@yhuang-dev> <4D52498D.9060706@web.de> <1297297678.17407.3.camel@yhuang-dev> <4D53A737.4090204@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , Anthony Liguori , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , Dean Nelson , Andi Kleen To: Jan Kiszka Return-path: Received: from mga11.intel.com ([192.55.52.93]:62391 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751546Ab1BKBUN (ORCPT ); Thu, 10 Feb 2011 20:20:13 -0500 In-Reply-To: <4D53A737.4090204@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 2011-02-10 at 16:52 +0800, Jan Kiszka wrote: > On 2011-02-10 01:27, Huang Ying wrote: > >>> @@ -1882,6 +1919,7 @@ int kvm_arch_on_sigbus_vcpu(CPUState *en > >>> hardware_memory_error(); > >>> } > >>> } > >>> + kvm_hwpoison_page_add(ram_addr); > >>> > >>> if (code == BUS_MCEERR_AR) { > >>> /* Fake an Intel architectural Data Load SRAR UCR */ > >>> @@ -1926,6 +1964,7 @@ int kvm_arch_on_sigbus(int code, void *a > >>> "QEMU itself instead of guest system!: %p\n", addr); > >>> return 0; > >>> } > >>> + kvm_hwpoison_page_add(ram_addr); > >>> kvm_mce_inj_srao_memscrub2(first_cpu, paddr); > >>> } else > >>> #endif > >>> > >>> > >> > >> Looks fine otherwise. Unless that simplification makes sense, I could > >> offer to include this into my MCE rework (there is some minor conflict). > >> If all goes well, that series should be posted during this week. > > Please have a look at > > git://git.kiszka.org/qemu-kvm.git queues/kvm-upstream > > and tell me if it works for you and your signed-off still applies. Thanks! Works as expected in my testing! Best Regards, Huang Ying