From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH 1/2] kvm tools: Set up tun interface using ioctls
Date: Wed, 13 Apr 2011 17:03:16 +0300
Message-ID: <1302703396.15231.24.camel@jaguar>
References: <1302696804-29684-1-git-send-email-levinsasha928@gmail.com>
	 <alpine.DEB.2.00.1104131649030.5456@tiger>  <4DA5AC37.1030602@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Sasha Levin <levinsasha928@gmail.com>, gorcunov@gmail.com,
	kvm@vger.kernel.org
To: Asias He <asias.hejun@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from filtteri6.pp.htv.fi ([213.243.153.189]:47362 "EHLO
	filtteri6.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752024Ab1DMODS (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 13 Apr 2011 10:03:18 -0400
In-Reply-To: <4DA5AC37.1030602@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, 2011-04-13 at 21:59 +0800, Asias He wrote:
> On 04/13/2011 09:49 PM, Pekka Enberg wrote:
> > On Wed, 13 Apr 2011, Sasha Levin wrote:
> >> Use ioctls to assign IP address and bring interface up instead of
> >> using ifconfig.
> >>
> >> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> >=20
> > I'm seeing this:
> >=20
> > penberg@tiger:~/linux/tools/kvm$ make
> >   GEN      include/common-cmds.h
> >   CC       8250-serial.o
> >   CC       virtio-blk.o
> >   CC       virtio-net.o
> > cc1: warnings being treated as errors
> > virtio-net.c: In function =E2=80=98virtio_net__init=E2=80=99:
> > virtio-net.c:302: error: dereferencing pointer =E2=80=98({anonymous=
})=E2=80=99 does
> > break strict-aliasing rules
> > virtio-net.c:302: note: initialized from here
> > make: *** [virtio-net.o] Error 1
>=20
> Hi, Pekka
>=20
> I am wondering why is your gcc always stricter than mine?

I have gcc 4.4.3 here. I wouldn't be surprised if those were actually
gcc bugs but and that we should turn off the aliasing checks. However,
for this particular case, it was pretty good at spotting questionable
code so... :-)

			Pekka