From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [PATCH 2/2] kvm tools: Make host side IP configurable Date: Wed, 13 Apr 2011 17:07:25 +0300 Message-ID: <1302703645.15231.26.camel@jaguar> References: <1302696804-29684-1-git-send-email-levinsasha928@gmail.com> <1302696804-29684-2-git-send-email-levinsasha928@gmail.com> <4DA59704.8@gmail.com> <4DA5A4E0.7060900@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Asias He , gorcunov@gmail.com, kvm@vger.kernel.org To: Sasha Levin Return-path: Received: from filtteri1.pp.htv.fi ([213.243.153.184]:56451 "EHLO filtteri1.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756226Ab1DMOH1 (ORCPT ); Wed, 13 Apr 2011 10:07:27 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 2011-04-13 at 16:38 +0300, Sasha Levin wrote: > On Wed, Apr 13, 2011 at 4:28 PM, Asias He wrote: > > On 04/13/2011 08:28 PM, Asias He wrote: > >> On 04/13/2011 08:13 PM, Sasha Levin wrote: > >>> Add --host-ip-addr parameter to allow changing the host-side IP address. > >> > >> > >> I'd personally prefer something like this: > >> > >> --network=model=virtio,hostip=x.x.x.x/mask,guestmac=yy:yy:yy:yy > >> > >> Once we can set up ip address for guest, we can use: > >> > >> --network=model=virtio,hostip=x.x.x.x/mask,guestmac=yy:yy:yy:yy,guestip=z.z.z.z/mask,guestgw=v.v.v.v > >> > > > > > > Alternatively, we can use an option group like this: > > > > Network options: > > -n --network > > -h --hostip > > -y --guestip > > -z --guestmac > > > > I agree. We can create a networking group once we start expanding the options. Asias, is the patch OK to merge?