Re: [PATCH 2/2] KVM: Use pci_store/load_saved_state() around VM device usage

Avi Kivity
2011-04-17T09:25:53Z

On 04/15/2011 10:54 PM, Alex Williamson wrote:
> Store the device saved state so that we can reload the device back
> to the original state when it's unassigned. This has the benefit
> that the state survives across pci_reset_function() calls via
> the PCI sysfs reset interface while the VM is using the device.

> @@ -516,7 +518,7 @@ static int kvm_vm_ioctl_assign_device(struct kvm *kvm,
>
> pci_reset_function(dev);
> pci_save_state(dev);
> -
> + match->pci_saved_state = pci_store_saved_state(dev);
> match->assigned_dev_id = assigned_dev->assigned_dev_id;

Error check?

It might be better to give up the opacity of the data structure and make
pci_saved_state the full struct, not a pointer.

--
error compiling committee.c: too many arguments to function