From: Sasha Levin <levinsasha928@gmail.com>
To: Asias He <asias.hejun@gmail.com>
Cc: Pekka Enberg <penberg@kernel.org>,
Cyrill Gorcunov <gorcunov@gmail.com>, Ingo Molnar <mingo@elte.hu>,
Prasad Joshi <prasadjoshi124@gmail.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 1/3] kvm tools: Make virtio-net kvm__irq_line thread safe
Date: Fri, 29 Apr 2011 10:53:26 +0300 [thread overview]
Message-ID: <1304063606.10069.7.camel@lappy> (raw)
In-Reply-To: <4DBA6519.5070509@gmail.com>
On Fri, 2011-04-29 at 15:13 +0800, Asias He wrote:
> On 04/29/2011 02:52 PM, Pekka Enberg wrote:
> > Please make that IRQ latency fix a separate patch. Don't we need to do
> > it for TX path as well, btw?
> >
>
> No. We only need it in RX path. Sasha's threadpool patch breaks this.
> I'm just moving it back.
>
I've moved the kvm__irq_line() call out because what would happen
sometimes is the following:
- Call kvm__irq_line() to signal completion.
- virt_queue__available() would return true.
- readv() call blocks.
I figured it happens because we catch virt_queue in while it's being
updated by the guest and use an erroneous state of it.
--
Sasha.
next prev parent reply other threads:[~2011-04-29 7:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 6:36 [PATCH 1/3] kvm tools: Make virtio-net kvm__irq_line thread safe Asias He
2011-04-29 6:36 ` [PATCH 2/3] kvm tools: Make virtio-console " Asias He
2011-04-29 6:44 ` Ingo Molnar
2011-04-29 6:36 ` [PATCH 3/3] kvm tools: Make virtio-blk " Asias He
2011-04-29 6:44 ` Ingo Molnar
2011-04-29 6:55 ` Pekka Enberg
2011-04-29 7:26 ` Asias He
2011-04-29 7:55 ` Pekka Enberg
2011-04-29 8:29 ` Sasha Levin
2011-04-29 6:46 ` [PATCH 1/3] kvm tools: Make virtio-net " Ingo Molnar
2011-04-29 6:52 ` Pekka Enberg
2011-04-29 7:13 ` Asias He
2011-04-29 7:15 ` Pekka Enberg
2011-04-29 7:38 ` Asias He
2011-04-29 7:45 ` Ingo Molnar
2011-04-29 7:53 ` Sasha Levin [this message]
2011-04-29 10:02 ` Cyrill Gorcunov
2011-04-29 10:37 ` Pekka Enberg
2011-04-29 10:47 ` Cyrill Gorcunov
2011-04-29 10:22 ` Ingo Molnar
2011-04-29 16:52 ` Sasha Levin
2011-04-29 20:39 ` Ingo Molnar
2011-04-29 7:30 ` Ingo Molnar
2011-04-29 7:47 ` Asias He
2011-04-29 10:32 ` Ingo Molnar
2011-04-29 10:42 ` Pekka Enberg
2011-04-29 17:43 ` Pekka Enberg
2011-04-29 19:59 ` Ingo Molnar
2011-04-30 7:44 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304063606.10069.7.camel@lappy \
--to=levinsasha928@gmail.com \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).