kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <levinsasha928@gmail.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Asias He <asias.hejun@gmail.com>,
	mingo@elte.hu, gorcunov@gmail.com, prasadjoshi124@gmail.com,
	kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH 3/6] kvm tools: Introduce generic IO threadpool
Date: Fri, 29 Apr 2011 14:12:39 +0300	[thread overview]
Message-ID: <1304075559.10069.21.camel@lappy> (raw)
In-Reply-To: <1304064977.10069.15.camel@lappy>

On Fri, 2011-04-29 at 15:08 +0800, Asias He wrote:
On 04/28/2011 09:40 PM, Sasha Levin wrote:
> > +	nr_online_cpus = sysconf(_SC_NPROCESSORS_ONLN);
> > +	thread_pool__init(nr_online_cpus);
> 
> We may benefit from more threads than the number of hardware thread we
> have. Currently, virtio_console consumes two,  virio_net consumes two,
> and virtio_blk consumes one. Can we adjust the thread pool size when
> devices register to use thread pool?

How many threads do we want to have the threadpool use?
Currently theres a thread allocated for each VCPU + _SC_NPROCESSORS_ONLN
I/O threads.

Should we just allocate another thread for each device that registers
within the threadpool? This number can grow to be pretty big once we
start adding multiple devices.


-- 

Sasha.


  parent reply	other threads:[~2011-04-29 11:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-28 13:40 [PATCH 1/6] kvm tools: Prevent duplicate definitions of ALIGN Sasha Levin
2011-04-28 13:40 ` [PATCH 2/6] kvm tools: Add kernel headers required for using list Sasha Levin
2011-04-28 13:40 ` [PATCH 3/6] kvm tools: Introduce generic IO threadpool Sasha Levin
2011-04-29  7:08   ` Asias He
     [not found]     ` <4DBA653A.90700@cs.helsinki.fi>
     [not found]       ` <1304064977.10069.15.camel@lappy>
2011-04-29 11:12         ` Sasha Levin [this message]
2011-04-28 13:40 ` [PATCH 4/6] kvm tools: Use threadpool for virtio-blk Sasha Levin
2011-04-28 13:40 ` [PATCH 5/6] kvm tools: Use threadpool for virtio-console Sasha Levin
2011-04-28 13:40 ` [PATCH 6/6] kvm tools: Use threadpool for virtio-net Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304075559.10069.21.camel@lappy \
    --to=levinsasha928@gmail.com \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=penberg@cs.helsinki.fi \
    --cc=prasadjoshi124@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).