From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: [PATCH 1/3] kvm tools: Lock job_mutex before signalling Date: Sat, 30 Apr 2011 16:30:23 +0300 Message-ID: <1304170225-4859-1-git-send-email-levinsasha928@gmail.com> Cc: mingo@elte.hu, asias.hejun@gmail.com, gorcunov@gmail.com, prasadjoshi124@gmail.com, kvm@vger.kernel.org, Sasha Levin To: penberg@kernel.org Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:33344 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756679Ab1D3Nae (ORCPT ); Sat, 30 Apr 2011 09:30:34 -0400 Received: by bwz15 with SMTP id 15so3694296bwz.19 for ; Sat, 30 Apr 2011 06:30:33 -0700 (PDT) Sender: kvm-owner@vger.kernel.org List-ID: Locking mutex before signalling to prevent unexpected scheduling. Signed-off-by: Sasha Levin --- tools/kvm/threadpool.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tools/kvm/threadpool.c b/tools/kvm/threadpool.c index c584ec7..700c08f 100644 --- a/tools/kvm/threadpool.c +++ b/tools/kvm/threadpool.c @@ -166,5 +166,7 @@ void thread_pool__signal_work(void *job) thread_pool__job_info_push_locked(job); mutex_unlock(&jobinfo->mutex); + mutex_lock(&job_mutex); pthread_cond_signal(&job_cond); + mutex_unlock(&job_mutex); } -- 1.7.5.rc3