From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: Asias He <asias.hejun@gmail.com>
Cc: autotest@test.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v2 1/2] KVM-test: Add qemu-ifup-atbr0
Date: Wed, 04 May 2011 00:23:15 -0300 [thread overview]
Message-ID: <1304479397.9850.22.camel@freedom> (raw)
In-Reply-To: <4DC0C3CE.8090109@gmail.com>
On Wed, 2011-05-04 at 11:11 +0800, Asias He wrote:
> On 05/04/2011 11:01 AM, Amos Kong wrote:
> > 'atbr0' is a private bridge.
> > This script is used to setup tap device.
> >
> > Signed-off-by: Amos Kong <akong@redhat.com>
> > ---
> > client/tests/kvm/scripts/qemu-ifup-atbr0 | 6 ++++++
> > 1 files changed, 6 insertions(+), 0 deletions(-)
> > create mode 100755 client/tests/kvm/scripts/qemu-ifup-atbr0
> >
> > diff --git a/client/tests/kvm/scripts/qemu-ifup-atbr0 b/client/tests/kvm/scripts/qemu-ifup-atbr0
> > new file mode 100755
> > index 0000000..82c7efa
> > --- /dev/null
> > +++ b/client/tests/kvm/scripts/qemu-ifup-atbr0
> > @@ -0,0 +1,6 @@
> > +#!/bin/sh
> > +switch=atbr0
> > +/sbin/ifconfig $1 0.0.0.0 up
> > +/usr/sbin/brctl addif ${switch} $1
> > +/usr/sbin/brctl setfd ${switch} 0
> > +/usr/sbin/brctl stp ${switch} off
>
> brctl is not in /usr/sbin but /sbin in some systems, e.g. Debian.
>
> hj:~# which brctl
> /sbin/brctl
>
> Does dropping this absolute path to brctl sound better?
I was planning to revive Jason's patchset that replaced the qemu ifup
scripts altogether. If the scripts were to be kept, yes, dropping the
absolute path sound good.
Thanks!
next prev parent reply other threads:[~2011-05-04 3:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1303184574.2088.4.camel@freedom>
2011-05-04 3:01 ` [PATCH v2 1/2] KVM-test: Add qemu-ifup-atbr0 Amos Kong
2011-05-04 3:11 ` Asias He
2011-05-04 3:23 ` Lucas Meneghel Rodrigues [this message]
2011-05-04 6:08 ` [PATCH v3 " Amos Kong
2011-05-04 6:10 ` [PATCH] KVM-test: Drop the absolute path of brctl/ifconfig Amos Kong
2011-05-04 3:01 ` [PATCH v2 2/2] KVM-test: Setup private bridge in framework Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304479397.9850.22.camel@freedom \
--to=lmr@redhat.com \
--cc=asias.hejun@gmail.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox