From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH 2/2 V2] kvm tools: Fix virt_queue__set_used_elem
Date: Wed, 04 May 2011 07:41:03 +0300
Message-ID: <1304484063.13143.9.camel@lappy>
References: <1304454487-2539-1-git-send-email-levinsasha928@gmail.com>
	 <1304454487-2539-2-git-send-email-levinsasha928@gmail.com>
	 <20110503204716.GA27887@elte.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: penberg@kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com,
	prasadjoshi124@gmail.com, kvm@vger.kernel.org
To: Ingo Molnar <mingo@elte.hu>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-ww0-f44.google.com ([74.125.82.44]:39727 "EHLO
	mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751094Ab1EDElJ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 4 May 2011 00:41:09 -0400
Received: by wwa36 with SMTP id 36so789899wwa.1
        for <kvm@vger.kernel.org>; Tue, 03 May 2011 21:41:08 -0700 (PDT)
In-Reply-To: <20110503204716.GA27887@elte.hu>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, 2011-05-03 at 22:47 +0200, Ingo Molnar wrote:
> * Sasha Levin <levinsasha928@gmail.com> wrote:
> 
> > Increase idx only after updating the used element.
> > Not doing so may mark a buffer as used without having
> > it's head and length updated.
> > 
> > Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> > ---
> >  tools/kvm/virtio.c |   19 ++++++++++++++++++-
> >  1 files changed, 18 insertions(+), 1 deletions(-)
> > 
> > diff --git a/tools/kvm/virtio.c b/tools/kvm/virtio.c
> > index 6249521..266a1b6 100644
> > --- a/tools/kvm/virtio.c
> > +++ b/tools/kvm/virtio.c
> > @@ -1,15 +1,32 @@
> >  #include <linux/virtio_ring.h>
> >  #include <stdint.h>
> >  #include <sys/uio.h>
> > +#include <asm/system.h>
> 
> If this system.h is included from the current kernel (and not from the 
> system's) then:
> 
> Acked-by: Ingo Molnar <mingo@elte.hu>
> 

The system.h that'll get picked up is
'../../arch/$(ARCH)/include/asm/system.h' within the current kernel tree
and not the system one.
> Thanks,
> 
> 	Ingo

-- 

Sasha.