public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <levinsasha928@gmail.com>
To: David Ahern <dsahern@gmail.com>
Cc: penberg@kernel.org, kvm@vger.kernel.org, mingo@elte.hu,
	asias.hejun@gmail.com, gorcunov@gmail.com,
	prasadjoshi124@gmail.com
Subject: Re: [PATCH 3/3 V2] kvm tools: Add cmdline options for loading multiple images
Date: Wed, 04 May 2011 18:03:43 +0300	[thread overview]
Message-ID: <1304521423.22299.8.camel@lappy> (raw)
In-Reply-To: <4DC167E5.1020707@gmail.com>

On Wed, 2011-05-04 at 08:51 -0600, David Ahern wrote:
> 
> On 05/04/11 07:45, Sasha Levin wrote:
> > This is a simple cmdline addition to allow loading multiple images.
> > perf's cmdline parser doesn't support having multiple args
> > with the same name (i.e. --image <img1> --image <img2>), so
> > we have to choose either to extend the parser, or find a diiferent
> > way to assign multiple images.
> > 
> > Sample cmdline for loading 2 images:
> > ./kvm run --image=image1.raw --readonly --image2=image2.raw --readonly2
> 
> syntax is getting a bit unwieldy. Why not use a scheme similar to qemu
> and concatenate related arguments into one and handle multiple usages?
> e.g., --image=image1.raw,ro --image=image2.raw,ro

That'll probably how it'll end up being. Currently the cmdline parser
doesn't support it and I didn't want to mix parser changes with
virtio-blk patch.

This patch should just allow testing of the multiple virtio-blk feature.

-- 

Sasha.


  reply	other threads:[~2011-05-04 15:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-04 13:45 [PATCH 0/3 V2] kvm tools: Support for multiple virtio-blk Sasha Levin
2011-05-04 13:45 ` [PATCH 1/3 V2] kvm tools: Move disk_image into virtio-blk Sasha Levin
2011-05-04 13:45 ` [PATCH 2/3 V2] kvm tools: Add support for multiple virtio-blk Sasha Levin
2011-05-04 13:56   ` Ingo Molnar
2011-05-04 14:32     ` Avi Kivity
2011-05-04 14:40       ` Asias He
2011-05-04 14:44     ` Sasha Levin
2011-05-04 14:51       ` Cyrill Gorcunov
2011-05-04 13:45 ` [PATCH 3/3 V2] kvm tools: Add cmdline options for loading multiple images Sasha Levin
2011-05-04 14:51   ` David Ahern
2011-05-04 15:03     ` Sasha Levin [this message]
2011-05-04 15:33       ` David Ahern
2011-05-04 19:38         ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304521423.22299.8.camel@lappy \
    --to=levinsasha928@gmail.com \
    --cc=asias.hejun@gmail.com \
    --cc=dsahern@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=penberg@kernel.org \
    --cc=prasadjoshi124@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox