From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH 2/2 V2] kvm tools: Fix virt_queue__set_used_elem
Date: Thu, 05 May 2011 10:18:06 +0300
Message-ID: <1304579886.9537.1.camel@lappy>
References: <1304454487-2539-1-git-send-email-levinsasha928@gmail.com>
	 <1304454487-2539-2-git-send-email-levinsasha928@gmail.com>
	 <20110503204716.GA27887@elte.hu> <1304484063.13143.9.camel@lappy>
	 <4DC1E57B.3060809@gmail.com> <20110505070211.GA13043@elte.hu>
	 <BANLkTikU76tDjdEBdXFTJvm-aH45oFGqkw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: Ingo Molnar <mingo@elte.hu>, Asias He <asias.hejun@gmail.com>,
	gorcunov@gmail.com, prasadjoshi124@gmail.com, kvm@vger.kernel.org
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wy0-f174.google.com ([74.125.82.174]:46206 "EHLO
	mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752254Ab1EEHSQ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 5 May 2011 03:18:16 -0400
Received: by wya21 with SMTP id 21so1379739wya.19
        for <kvm@vger.kernel.org>; Thu, 05 May 2011 00:18:14 -0700 (PDT)
In-Reply-To: <BANLkTikU76tDjdEBdXFTJvm-aH45oFGqkw@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, 2011-05-05 at 10:13 +0300, Pekka Enberg wrote:
> On Thu, May 5, 2011 at 10:02 AM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > * Asias He <asias.hejun@gmail.com> wrote:
> >
> >> With commit d7f0c07afeefa2d20739437306e4b8bb2853cf83 in master
> >> (kvm tools: Fix virt_queue__set_used_elem)
> >>
> >> I see this:
> >>
> >> asias@hj:~/qemu-stuff/pekka.git/tools/kvm$ make
> >>   GEN      include/common-cmds.h
> >> ../../include/asm-generic/bitops/fls64.h:33:2: error: #error
> >> BITS_PER_LONG not 32 or 64
> >
> > The build fails here too, in a similar way, on a 32-bit Fedora 14 box.
> 
> Curious. It works fine on my box. I think it's missing #include
> <asm/bitsperlong.h>. I wonder why system.h isn't pulling that
> itself...

Pekka, Are you on a 64bit box?
I suspect it's not working on 32bit boxes.

-- 

Sasha.