From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH 2/3] kvm tools: Introduce virtio-rng Date: Thu, 05 May 2011 10:20:00 +0300 Message-ID: <1304580000.9537.3.camel@lappy> References: <1304170225-4859-1-git-send-email-levinsasha928@gmail.com> <1304170225-4859-2-git-send-email-levinsasha928@gmail.com> <20110505065423.GD28015@elte.hu> <20110505071241.GB13768@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Ingo Molnar , asias.hejun@gmail.com, gorcunov@gmail.com, prasadjoshi124@gmail.com, kvm@vger.kernel.org To: Pekka Enberg Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:38479 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751990Ab1EEHUJ (ORCPT ); Thu, 5 May 2011 03:20:09 -0400 Received: by wya21 with SMTP id 21so1380676wya.19 for ; Thu, 05 May 2011 00:20:08 -0700 (PDT) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 2011-05-05 at 10:14 +0300, Pekka Enberg wrote: > On Thu, May 5, 2011 at 10:12 AM, Ingo Molnar wrote: > > another thing i noticed: the patch introduces some new uint_* usages. > > > > Once things are fixed can we somehow kill that datatype intelligently, so that > > if new code uses it the build breaks or so? > > I guess we could do > > include/stdint.h > > that does > > #error You lose. > > or something. I'll make a pass to clean up formatting and datatypes throughout the virtio drivers once I finish with the virtio-blk patch. -- Sasha.