From: Sasha Levin <levinsasha928@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Asias He <asias.hejun@gmail.com>,
gorcunov@gmail.com, prasadjoshi124@gmail.com,
kvm@vger.kernel.org
Subject: Re: [PATCH 2/2 V2] kvm tools: Fix virt_queue__set_used_elem
Date: Thu, 05 May 2011 11:01:33 +0300 [thread overview]
Message-ID: <1304582493.9537.5.camel@lappy> (raw)
In-Reply-To: <BANLkTi=Lg7K-hXBKRCFv48MkiKY_bwL2QA@mail.gmail.com>
On Thu, 2011-05-05 at 10:52 +0300, Pekka Enberg wrote:
> On Thu, May 5, 2011 at 10:47 AM, Ingo Molnar <mingo@elte.hu> wrote:
> >> > The build fails here too, in a similar way, on a 32-bit Fedora 14 box.
> >>
> >> Curious. It works fine on my box. I think it's missing #include
> >> <asm/bitsperlong.h>. I wonder why system.h isn't pulling that
> >> itself...
> >
> > asm/system.h is one of the messier kernel headers, so i'm not surprised it has
> > assymetric requirements on 64-bit and 32-bit systems.
>
> So does including <asm/bitsperlong.h> before <asm/system.h> fix the
> problem on 32-bit boxes? If so, I'd prefer we fix it like that for
> now.
>
> > We could fix it (provide those dependencies), or we could pick
> > tools/perf/perf.h's mb() definitions. That's much cruder than the nice kernel
> > memory barriers though ...
>
> That's the second best option, I think.
I agree with Pekka, For the same reasons we provided the dependencies
for including <linux/list.h> instead of just taking the source.
--
Sasha.
next prev parent reply other threads:[~2011-05-05 8:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 20:28 [PATCH 1/2 V2] kvm tools: Drop ALIGN from bios.h Sasha Levin
2011-05-03 20:28 ` [PATCH 2/2 V2] kvm tools: Fix virt_queue__set_used_elem Sasha Levin
2011-05-03 20:47 ` Ingo Molnar
2011-05-04 4:41 ` Sasha Levin
2011-05-04 6:33 ` Ingo Molnar
2011-05-04 23:47 ` Asias He
2011-05-05 4:38 ` Sasha Levin
2011-05-05 7:02 ` Ingo Molnar
2011-05-05 7:13 ` Pekka Enberg
2011-05-05 7:18 ` Sasha Levin
2011-05-05 7:32 ` Pekka Enberg
2011-05-05 7:47 ` Ingo Molnar
2011-05-05 7:52 ` Pekka Enberg
2011-05-05 8:01 ` Sasha Levin [this message]
2011-05-05 8:07 ` Ingo Molnar
2011-05-05 8:12 ` Ingo Molnar
2011-05-05 8:22 ` [PATCH] kvm: Fix 32-bit build of the asm/system.h include Ingo Molnar
2011-05-05 14:45 ` Pekka Enberg
2011-05-05 15:33 ` Asias He
2011-05-03 20:35 ` [PATCH 1/2 V2] kvm tools: Drop ALIGN from bios.h Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304582493.9537.5.camel@lappy \
--to=levinsasha928@gmail.com \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox