public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <levinsasha928@gmail.com>
To: penberg@kernel.org
Cc: mingo@elte.hu, asias.hejun@gmail.com, gorcunov@gmail.com,
	prasadjoshi124@gmail.com, kvm@vger.kernel.org,
	Sasha Levin <levinsasha928@gmail.com>
Subject: [PATCH 1/2] kvm tools: Fix IRQ assignments
Date: Fri,  6 May 2011 10:26:34 +0300	[thread overview]
Message-ID: <1304666795-15251-1-git-send-email-levinsasha928@gmail.com> (raw)

virtio-blk needs a block of 4 IRQs (currently - staticly defined).
Giving the initial IRQ of 15 causes breakage when adding more
than one device.

Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
---
 tools/kvm/include/kvm/virtio-pci-dev.h |   14 ++++++++++----
 1 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/tools/kvm/include/kvm/virtio-pci-dev.h b/tools/kvm/include/kvm/virtio-pci-dev.h
index 431289d..41125c2 100644
--- a/tools/kvm/include/kvm/virtio-pci-dev.h
+++ b/tools/kvm/include/kvm/virtio-pci-dev.h
@@ -31,10 +31,16 @@ enum {
 };
 
 enum {
-	VIRTIO_RNG_IRQ				= 11,
-	VIRTIO_CONSOLE_IRQ			= 13,
-	VIRTIO_NET_IRQ				= 14,
-	VIRTIO_BLK_IRQ				= 15,
+	VIRTIO_RNG_IRQ				= 9,
+	VIRTIO_CONSOLE_IRQ			= 10,
+	VIRTIO_NET_IRQ				= 11,
+	VIRTIO_BLK_IRQ				= 12,
+	/*
+	 * FIXME: Currently IRQs 12-15 are reserved for possible
+	 * virtio-blk devices. Static assignment will be avoided
+	 * once dynamic IRQ assignment is added (or switch to
+	 * MSI-X).
+	 */
 };
 
 #endif /* VIRTIO_PCI_DEV_H_ */
-- 
1.7.5.rc3


             reply	other threads:[~2011-05-06  7:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-06  7:26 Sasha Levin [this message]
2011-05-06  7:26 ` [PATCH 2/2] kvm tools: Simplify search for root device Sasha Levin
2011-05-07  8:41   ` Pekka Enberg
2011-05-07  8:46     ` Sasha Levin
2011-05-07  8:49     ` Prasad Joshi
2011-05-06  7:29 ` [PATCH 1/2] kvm tools: Fix IRQ assignments Pekka Enberg
2011-05-06  7:31   ` Cyrill Gorcunov
2011-05-06  7:36   ` Sasha Levin
2011-05-06  7:43     ` Pekka Enberg
2011-05-06  8:01       ` Sasha Levin
2011-05-06  8:04         ` Pekka Enberg
2011-05-06  8:08           ` Cyrill Gorcunov
2011-05-06  8:10             ` Pekka Enberg
2011-05-06  8:16               ` Cyrill Gorcunov
2011-05-06  7:47     ` Cyrill Gorcunov
2011-05-06  7:59       ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304666795-15251-1-git-send-email-levinsasha928@gmail.com \
    --to=levinsasha928@gmail.com \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=penberg@kernel.org \
    --cc=prasadjoshi124@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox