From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH v2 4/4] kvm tools: Fix virtio console hangs by removing
 IRQ injection for tx path
Date: Sun, 08 May 2011 20:29:28 +0300
Message-ID: <1304875768.12850.5.camel@lappy>
References: <1304860165-28810-1-git-send-email-asias.hejun@gmail.com>
	 <1304860165-28810-5-git-send-email-asias.hejun@gmail.com>
	 <1304874329.10621.45.camel@jaguar> <1304875308.12850.1.camel@lappy>
	 <BANLkTimUO=atXLV-m=jzLCufKQZAFG7d2Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: Asias He <asias.hejun@gmail.com>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	Ingo Molnar <mingo@elte.hu>,
	Prasad Joshi <prasadjoshi124@gmail.com>, kvm@vger.kernel.org
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-ww0-f44.google.com ([74.125.82.44]:38650 "EHLO
	mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753921Ab1EHR3p (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 8 May 2011 13:29:45 -0400
Received: by wwa36 with SMTP id 36so5041456wwa.1
        for <kvm@vger.kernel.org>; Sun, 08 May 2011 10:29:43 -0700 (PDT)
In-Reply-To: <BANLkTimUO=atXLV-m=jzLCufKQZAFG7d2Q@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, 2011-05-08 at 20:28 +0300, Pekka Enberg wrote:
> On Sun, May 8, 2011 at 8:21 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
> > I'm seeing no more hangs, but why enable it unconditionally?
> > Maybe enable it by default, but we shouldn't force the activation of
> > virtio modules if the user doesn't want them.
> 
> I meant enabling the device on PCI bus like we did before.

Thats what I've meant too. virtio-console is the only device which got
initialized even if it wasn't requested (even when '-c serial' was
passed specifically).

-- 

Sasha.