From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH v2 4/4] kvm tools: Fix virtio console hangs by removing
 IRQ injection for tx path
Date: Sun, 08 May 2011 20:35:24 +0300
Message-ID: <1304876124.12850.6.camel@lappy>
References: <1304860165-28810-1-git-send-email-asias.hejun@gmail.com>
	 <1304860165-28810-5-git-send-email-asias.hejun@gmail.com>
	 <1304874329.10621.45.camel@jaguar> <1304875308.12850.1.camel@lappy>
	 <BANLkTimUO=atXLV-m=jzLCufKQZAFG7d2Q@mail.gmail.com>
	 <1304875768.12850.5.camel@lappy>
	 <BANLkTikK-kzuZEyWM71kDuWQ1zNtejv0Ew@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: Asias He <asias.hejun@gmail.com>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	Ingo Molnar <mingo@elte.hu>,
	Prasad Joshi <prasadjoshi124@gmail.com>, kvm@vger.kernel.org
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wy0-f174.google.com ([74.125.82.174]:59807 "EHLO
	mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754039Ab1EHRfk (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 8 May 2011 13:35:40 -0400
Received: by wya21 with SMTP id 21so3403630wya.19
        for <kvm@vger.kernel.org>; Sun, 08 May 2011 10:35:39 -0700 (PDT)
In-Reply-To: <BANLkTikK-kzuZEyWM71kDuWQ1zNtejv0Ew@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, 2011-05-08 at 20:34 +0300, Pekka Enberg wrote:
> On Sun, May 8, 2011 at 8:29 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
> > On Sun, 2011-05-08 at 20:28 +0300, Pekka Enberg wrote:
> >> On Sun, May 8, 2011 at 8:21 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
> >> > I'm seeing no more hangs, but why enable it unconditionally?
> >> > Maybe enable it by default, but we shouldn't force the activation of
> >> > virtio modules if the user doesn't want them.
> >>
> >> I meant enabling the device on PCI bus like we did before.
> >
> > Thats what I've meant too. virtio-console is the only device which got
> > initialized even if it wasn't requested (even when '-c serial' was
> > passed specifically).
> 
> The more options we have, the more combinations we need to test.
> What's the downside of enabling virtio console by default? The upside
> is that it's less likely to break. Btw, we should probably do that for
> virtio rng as well.

I fully support enabling it by default, I'm against enabling it even if
the user asked to have it disabled.

-- 

Sasha.