From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH] kvm tools: Fix type mismatches on GCC 4.4 on 32-bit
 systems
Date: Fri, 13 May 2011 12:11:57 +0300
Message-ID: <1305277917.25256.2.camel@lappy>
References: <20110513081909.GA14603@elte.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-7
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	KVM devel mailing list <kvm@vger.kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-fx0-f46.google.com ([209.85.161.46]:59057 "EHLO
	mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932478Ab1EMJML (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 13 May 2011 05:12:11 -0400
Received: by fxm17 with SMTP id 17so1627550fxm.19
        for <kvm@vger.kernel.org>; Fri, 13 May 2011 02:12:10 -0700 (PDT)
In-Reply-To: <20110513081909.GA14603@elte.hu>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, 2011-05-13 at 10:19 +0200, Ingo Molnar wrote:
> FYI, the tools/kvm build still fails on 32-bit:
>=20
>  cc1: warnings being treated as errors
>  qcow.c: In function =A1qcow1_write_sector=A2:
>  qcow.c:307: error: comparison between signed and unsigned integer ex=
pressions
>  make: *** [qcow.o] Error 1
>  make: *** Waiting for unfinished jobs....
>=20
> using:
>=20
>  gcc version 4.4.4 20100630 (Red Hat 4.4.4-10) (GCC)
>=20
> The patch below addresses them but i haven't tested it beyond checkin=
g that it=20
> builds.
>=20
> The double cast of userspace_addr is doubly sad - it highlights our 3=
2-bitness=20
> problems which are visible in the guest_pfn_to_host() function as wel=
l.

KVM API uses 64-bit addresses no matter the host bitness, so we can't
really get around doing these sort of casts.

--=20

Sasha.