From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH 1/2] kvm tools: Bring VIRTIO_BLK_F_SEG_MAX feature back
 to virtio blk
Date: Fri, 13 May 2011 17:07:53 +0300
Message-ID: <1305295673.25256.16.camel@lappy>
References: <1305254409-9079-1-git-send-email-asias.hejun@gmail.com>
	 <4DCD2833.7080803@cs.helsinki.fi>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: Asias He <asias.hejun@gmail.com>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	Ingo Molnar <mingo@elte.hu>,
	Prasad Joshi <prasadjoshi124@gmail.com>, kvm@vger.kernel.org
To: Pekka Enberg <penberg@cs.helsinki.fi>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-ew0-f46.google.com ([209.85.215.46]:62472 "EHLO
	mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757221Ab1EMOIK (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 13 May 2011 10:08:10 -0400
Received: by ewy4 with SMTP id 4so715234ewy.19
        for <kvm@vger.kernel.org>; Fri, 13 May 2011 07:08:09 -0700 (PDT)
In-Reply-To: <4DCD2833.7080803@cs.helsinki.fi>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, 2011-05-13 at 15:46 +0300, Pekka Enberg wrote:
> On 5/13/11 5:40 AM, Asias He wrote:
> > commit b764422bb0b46b00b896f6d4538ac3d3dde9e56b
> > (kvm tools: Add support for multiple virtio-blk)
> > removed the VIRTIO_BLK_F_SEG_MAX publishment to guest.
> >
> > There is no reason we should not support it. Just bring it back.
> >
> > Signed-off-by: Asias He<asias.hejun@gmail.com>
> 
> Sasha?

I'm not sure why it was removed, must have missed it when updating
struct blk_dev.

On the other hand, why do we need to limit max segment size?

-- 

Sasha.