From: Sasha Levin <levinsasha928@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
asias.hejun@gmail.com, prasadjoshi124@gmail.com,
gorcunov@gmail.com, kvm@vger.kernel.org, john@jfloren.net
Subject: Re: [PATCH 1/2] kvm tools: Add interval red-black tree helper
Date: Tue, 17 May 2011 11:21:05 +0300 [thread overview]
Message-ID: <1305620465.12150.24.camel@sasha> (raw)
In-Reply-To: <BANLkTi=FOOytPOd7f6pYJeFAKUiMXfJhkw@mail.gmail.com>
On Tue, 2011-05-17 at 11:18 +0300, Pekka Enberg wrote:
> On Tue, May 17, 2011 at 11:05 AM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > * Sasha Levin <levinsasha928@gmail.com> wrote:
> >
> >> On Tue, 2011-05-17 at 09:41 +0200, Ingo Molnar wrote:
> >> > * Sasha Levin <levinsasha928@gmail.com> wrote:
> >> > > +#include <kvm/interval-rbtree.h>
> >> > > +#include <stdio.h>
> >> > > +#include <stdlib.h>
> >> >
> >> > At first sight i dont think you really need the stdio.h and stlib.h includes -
> >> > you added these while having debugging printfs in the code?
> >>
> >> We can drop either of them, but not both. Added it for size_t
> >> definition.
> >
> > Oh, ok - sure!
>
> I think
>
> #include <stddef.h>
>
> is the right thing to do here, no?
Yup, That'll be better.
--
Sasha.
prev parent reply other threads:[~2011-05-17 8:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 6:58 [PATCH 1/2] kvm tools: Add interval red-black tree helper Sasha Levin
2011-05-17 6:58 ` [PATCH 2/2] kvm tools: Add MMIO address mapper Sasha Levin
2011-05-17 7:42 ` Ingo Molnar
2011-05-17 7:41 ` [PATCH 1/2] kvm tools: Add interval red-black tree helper Ingo Molnar
2011-05-17 7:55 ` Sasha Levin
2011-05-17 8:05 ` Ingo Molnar
2011-05-17 8:18 ` Pekka Enberg
2011-05-17 8:21 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305620465.12150.24.camel@sasha \
--to=levinsasha928@gmail.com \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=john@jfloren.net \
--cc=kvm@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox