From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH 1/2] kvm tools: Add interval red-black tree helper Date: Tue, 17 May 2011 11:21:05 +0300 Message-ID: <1305620465.12150.24.camel@sasha> References: <1305615515-13913-1-git-send-email-levinsasha928@gmail.com> <20110517074115.GG22305@elte.hu> <1305618929.12150.23.camel@sasha> <20110517080531.GC22093@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Ingo Molnar , asias.hejun@gmail.com, prasadjoshi124@gmail.com, gorcunov@gmail.com, kvm@vger.kernel.org, john@jfloren.net To: Pekka Enberg Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:54828 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751188Ab1EQIVJ (ORCPT ); Tue, 17 May 2011 04:21:09 -0400 Received: by fxm17 with SMTP id 17so247239fxm.19 for ; Tue, 17 May 2011 01:21:08 -0700 (PDT) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 2011-05-17 at 11:18 +0300, Pekka Enberg wrote: > On Tue, May 17, 2011 at 11:05 AM, Ingo Molnar wrote: > > > > * Sasha Levin wrote: > > > >> On Tue, 2011-05-17 at 09:41 +0200, Ingo Molnar wrote: > >> > * Sasha Levin wrote: > >> > > +#include > >> > > +#include > >> > > +#include > >> > > >> > At first sight i dont think you really need the stdio.h and stlib.h includes - > >> > you added these while having debugging printfs in the code? > >> > >> We can drop either of them, but not both. Added it for size_t > >> definition. > > > > Oh, ok - sure! > > I think > > #include > > is the right thing to do here, no? Yup, That'll be better. -- Sasha.