From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH] kvm tools, 9p: Test for tuncation result
Date: Sat, 21 May 2011 17:03:12 +0300
Message-ID: <1305986592.27595.0.camel@lappy>
References: <4DD7ABBA.6090405@gmail.com>
	 <BANLkTimR-CsW-tqMqM8odJVnAsnZz3689A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-7
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Cyrill Gorcunov <gorcunov@gmail.com>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Ingo Molnar <mingo@elte.hu>, Asias He <asias.hejun@gmail.com>,
	Chaitanya Kulkarni <chaitanyakulkarni15@gmail.com>,
	Prasad Joshi <prasadjoshi124@gmail.com>,
	Thomas Heil <heil@terminal-consulting.de>,
	kvm-vger <kvm@vger.kernel.org>
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wy0-f174.google.com ([74.125.82.174]:45329 "EHLO
	mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751936Ab1EUODX (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 21 May 2011 10:03:23 -0400
Received: by wya21 with SMTP id 21so3289287wya.19
        for <kvm@vger.kernel.org>; Sat, 21 May 2011 07:03:22 -0700 (PDT)
In-Reply-To: <BANLkTimR-CsW-tqMqM8odJVnAsnZz3689A@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sat, 2011-05-21 at 16:35 +0300, Pekka Enberg wrote:
> On Sat, May 21, 2011 at 3:10 PM, Cyrill Gorcunov <gorcunov@gmail.com>=
 wrote:
> > Without 'ret' usage I get
> >
> >  | cyrill@sun kvm $ make
> >  |  CC       virtio/9p.o
> >  | virtio/9p.c: In function =A1virtio_p9_wstat=A2:
> >  | virtio/9p.c:448:6: error: variable =A1res=A2 set but not used [-=
Werror=3Dunused-but-set-variable]
> >  | cc1: all warnings being treated as errors
> >  | make: *** [virtio/9p.o] Error 1
> >
> > so add a basic check for ftruncate result, this eliminate warning a=
nd
> > we might need to use 'res' status later in caller code.
> >
> > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> > CC: Sasha Levin <levinsasha928@gmail.com>
>=20
> Sasha?

Looks good to me.

Acked-by: Sasha Levin <levinsasha928@gmail.com>

> > ---
> >
> > Pekka, are you fine with 'kvm-tools,9p' prefix?
>=20
> Sure.

--=20

Sasha.