Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Niklas Schnelle <schnelle@linux.ibm.com>
To: Omar Elghoul <oelghoul@linux.ibm.com>,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org
Cc: hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com,
	borntraeger@linux.ibm.com, svens@linux.ibm.com,
	mjrosato@linux.ibm.com, alifm@linux.ibm.com,
	farman@linux.ibm.com, gbayer@linux.ibm.com, alex@shazbot.org
Subject: Re: [PATCH v5 2/4] s390/pci: Preserve FMB state in device re-enablement
Date: Wed, 01 Jul 2026 10:34:27 +0200	[thread overview]
Message-ID: <1305d6eab67c4e7d751841a8894697ec851bd907.camel@linux.ibm.com> (raw)
In-Reply-To: <20260626175525.37370-3-oelghoul@linux.ibm.com>

On Fri, 2026-06-26 at 13:55 -0400, Omar Elghoul wrote:
> Introduce a function zpci_fmb_reenable_device() that checks the state of
> the FMB and ensures it is enabled. Reset the counters to zero, disable, and
> re-enable the FMB if it was already enabled. Call this function during a
> zPCI device re-enablement, which in turn implicitly ensures that the FMB is
> enabled for host devices during their KVM registration.
> 
> Signed-off-by: Omar Elghoul <oelghoul@linux.ibm.com>
> ---

Just to keep the list up to date. We're still discussing some details
about this internally. Mostly about how this may interact with platform
behavior in some edge cases that are likely not possible with current
implementations but would be covered by the architecture. 

Personally, I actually liked the re-using of the buffer in v4 better
and I think depending on implementations of the kmem_cache,
specifically if it may give us back the same buffer that we just freed
in the immediately following allocation, this could also end up re-
using the same buffer anyway. Hope to get the details sorted soon.

Thanks,
Niklas

  parent reply	other threads:[~2026-07-01  8:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-26 17:55 [PATCH v5 0/4] vfio-pci/zdev: Improved zPCI Function Measurement Support Omar Elghoul
2026-06-26 17:55 ` [PATCH v5 1/4] s390/pci: Hold fmb_lock when enabling or disabling PCI devices Omar Elghoul
2026-06-26 18:12   ` sashiko-bot
2026-06-26 17:55 ` [PATCH v5 2/4] s390/pci: Preserve FMB state in device re-enablement Omar Elghoul
2026-06-26 18:06   ` sashiko-bot
2026-07-01  8:34   ` Niklas Schnelle [this message]
2026-06-26 17:55 ` [PATCH v5 3/4] s390/pci: Fence FMB enable/disable via debugfs for passthrough devices Omar Elghoul
2026-06-26 17:55 ` [PATCH v5 4/4] vfio-pci/zdev: Add VFIO FMB device features Omar Elghoul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305d6eab67c4e7d751841a8894697ec851bd907.camel@linux.ibm.com \
    --to=schnelle@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=alex@shazbot.org \
    --cc=alifm@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=farman@linux.ibm.com \
    --cc=gbayer@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mjrosato@linux.ibm.com \
    --cc=oelghoul@linux.ibm.com \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox