Re: [PATCH 0/4] Make possible to run client tests as subtests

[Lucas Meneghel Rodrigues <lmr@redhat.com>]

On Tue, 2011-05-24 at 04:08 -0300, Lucas Meneghel Rodrigues wrote:
> In order to avoid duplication of code, make it possible to run the
> existing autotest client tests as subtests. This patchset is result
> of work on Jiri Zupka original single patch, the differences:
> 
> * Removed example subtest KVM autotest test
> * Renamed some API introduced to net_utils for consistency
> * Rewrote netperf in terms of the new 'subtest' infrastructure

For the record of documentation, there are still some things bothering
me with this patchset:

* I still didn't check whether the changes to autotest core (test class)
do break unittests. We might want to write a unittest for the new
methods of the test class.
* Maybe rather than simply calling job.runtest() we would be better of
executing the subtest on a new thread?
* The netperf reimplementation clearly lacks the functionality of the
current implementation. We need more work on it.

I asked Jiri to pick the patchset and look at these points of
improvement.

> Lucas Meneghel Rodrigues (4):
>   client.bin.net.net_utils: Introduce get_local_ip()
>   client: Make it possible to run subtests in autotest
>   tools: Make html_report to deal with subtest results
>   KVM test: Rewrite netperf in terms of subtest
> 
>  client/bin/client_logging_config.py |    5 +-
>  client/bin/net/net_utils.py         |   17 +++++
>  client/common_lib/base_job.py       |    2 +
>  client/common_lib/logging_config.py |    3 +-
>  client/common_lib/test.py           |   21 ++++++-
>  client/tools/html_report.py         |  124 +++++++++++++++++++---------------
>  client/virt/tests/netperf.py        |  117 +++++++++------------------------
>  7 files changed, 143 insertions(+), 146 deletions(-)
>