public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org, Jan Kiszka <jan.kiszka@siemens.com>
Subject: [PATCH] testdev: adjust for ISA irq changes
Date: Sun, 29 May 2011 08:57:31 -0400	[thread overview]
Message-ID: <1306673851-23152-1-git-send-email-avi@redhat.com> (raw)

Recent changes killed the ioapic_irq_hack hack, use the isa_get_irq() API
instead.

Signed-off-by: Avi Kivity <avi@redhat.com>
---
 hw/isa-bus.c |    2 +-
 hw/testdev.c |    4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/hw/isa-bus.c b/hw/isa-bus.c
index 2765543..7e06efc 100644
--- a/hw/isa-bus.c
+++ b/hw/isa-bus.c
@@ -66,7 +66,7 @@ void isa_bus_irqs(qemu_irq *irqs)
  */
 qemu_irq isa_get_irq(int isairq)
 {
-    if (isairq < 0 || isairq > 15) {
+    if (isairq < 0 || isairq > 23) {
         hw_error("isa irq %d invalid", isairq);
     }
     return isabus->irqs[isairq];
diff --git a/hw/testdev.c b/hw/testdev.c
index f0355c8..bf1611c 100644
--- a/hw/testdev.c
+++ b/hw/testdev.c
@@ -28,11 +28,9 @@ static uint32_t test_device_memsize_read(void *opaque, uint32_t addr)
     return ram_size;
 }
 
-extern qemu_irq *ioapic_irq_hack;
-
 static void test_device_irq_line(void *opaque, uint32_t addr, uint32_t data)
 {
-    qemu_set_irq(ioapic_irq_hack[addr - 0x2000], !!data);
+    qemu_set_irq(isa_get_irq(addr - 0x2000), !!data);
 }
 
 static uint32 test_device_ioport_data;
-- 
1.7.5.2


             reply	other threads:[~2011-05-29 12:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-29 12:57 Avi Kivity [this message]
2011-05-29 15:05 ` [PATCH] testdev: adjust for ISA irq changes Jan Kiszka
2011-05-29 15:10   ` Avi Kivity
2011-05-29 15:21     ` Jan Kiszka
2011-05-29 15:26       ` Avi Kivity
2011-05-29 15:36         ` Jan Kiszka
2011-05-30 15:34           ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306673851-23152-1-git-send-email-avi@redhat.com \
    --to=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox